mahout-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Drew Farris (JIRA)" <j...@apache.org>
Subject [jira] Commented: (MAHOUT-222) Colt collections work in progress
Date Mon, 14 Dec 2009 19:41:18 GMT

    [ https://issues.apache.org/jira/browse/MAHOUT-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790309#action_12790309
] 

Drew Farris commented on MAHOUT-222:
------------------------------------

This looks ok to me as far as code content is concerned. FWIW, I did notice however that OpenIntIntHashMap
and its test and GenericSortingTest use tabs instead of two spaces per level. The project
style convention dictates using two spaces, see http://cwiki.apache.org/MAHOUT/howtocontribute.html.
Once that's fixed it would be great if someone could commit this.





> Colt collections work in progress
> ---------------------------------
>
>                 Key: MAHOUT-222
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-222
>             Project: Mahout
>          Issue Type: Improvement
>          Components: Matrix
>    Affects Versions: 0.4
>            Reporter: Benson Margulies
>         Attachments: mahout-222-ready.patch
>
>
> I am attaching a patch that shows my current work state on polishing the colt collections
code. My primary target is the int-int hash map, but I've also started work on extending it
to an int-char hash map. No one should even think about committing this yet, I'm posting so
that people can see what I'm up to.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message