mahout-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benson Margulies <bimargul...@gmail.com>
Subject Re: Checkstyle
Date Mon, 20 Jul 2009 13:14:40 GMT
Here's an example:

/Users/benson/x/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/hadoop/SlopeOneDiffsToAveragesReducer.java:30:
method def throws at indentation level 6 not at correct indentation, 4

It looks like if throws is on its own line it does not get indented.



On Mon, Jul 20, 2009 at 9:11 AM, Sean Owen<srowen@gmail.com> wrote:
> Meh, if we have to change that indentation style in those hundred
> cases to something slightly different to appease checkstyle, I'm cool
> with it. What does it want to see?
>
> On Mon, Jul 20, 2009 at 2:08 PM, Benson Margulies<bimargulies@gmail.com> wrote:
>> See
>>
>> http://www.nabble.com/Indentation-problem-with-long-method-signature-and-throws-td16427361.html
>>
>>
>> There are about 110 examples where the style in use in the code base
>> runs into this, which sadly seems to be an immutable opinion of
>> checkstyle.
>>
>> I don't know of any way to automate style checks except checkstyle.
>> So, either folks have to be willing to accept it's view of this
>> situation, or I need to turn off indentation checking.
>>
>

Mime
View raw message