mahout-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benson Margulies <bimargul...@gmail.com>
Subject Re: Code quality enforcement?
Date Thu, 09 Jul 2009 14:19:13 GMT
Once you do this, I will try to make checkstyle and pmd play along. In
my past experience it's a lot easier to do this by using them as the
vocabulary/specification, but we'll see what happens.

On Thu, Jul 9, 2009 at 5:01 AM, Sean Owen<srowen@gmail.com> wrote:
> Alright, well I am going to apply a big reformatting patch today --
> assuming nobody has some outstanding patch they really don't want to
> break. If so, say so and get it submitted soon I guess.
>
> While we're at it, can we discuss and maybe agree on a few more points of style:
>
> - Line length: I propose 120 column limit#
> - Always use braces for one-line loops (?)
> - Order imports alphabetically ideally, no * imports, group by package
> - static members, instance members, constructors, (everything else),
> inner classes?
> - All files have copyright statement at very top, before package statement
> - No empty javadoc or placeholder "non-Javadoc" stuff from Eclipse
> - No System.out/System.err, except maybe in classes that are
> command-line programs; all logging through slf4j
>
> I could keep going (no non-private instance fields, etc.) but this
> seems like enough to start. Are there thoughts on any of this... if
> there is even mild disagreement I don't want to bother pushing these
> changes.
>
> On Wed, Jul 8, 2009 at 10:19 PM, Isabel Drost<isabel@apache.org> wrote:
>> On Tuesday 07 July 2009 22:14:14 Benson Margulies wrote:
>>> In CXF and XMLSchema, we use both checkstyle and eclipse to enforce
>>> coding style and standards. There is technology to run this stuff from
>>> maven and to cause the maven-eclipse-plugin to configure it into
>>> eclipse.
>>
>> +1 from me as well. I also like the reports on code duplication, test coverage
>> and the like. If published online these reports help users to get a first
>> impression of code quality and coding standards...
>

Mime
View raw message