Mailing-List: contact mahout-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mahout-dev@lucene.apache.org
Received-SPF: neutral (nike.apache.org: local policy)
Message-Id: <A2C40395-BB3B-4F4E-A865-4D53C041288A@apache.org>
From: Grant Ingersoll <gsingers@apache.org>
To: mahout-dev@lucene.apache.org
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v935.3)
Subject: A Bunch of Vector questions
Date: Tue, 9 Jun 2009 17:49:06 -0400

I'm looking into the whole labels thing as well as Vector stuff and  
I'm confused by a couple of things.

1. DirchletMapper assumes DenseVector implementation, no?  Line 45?

2. Shouldn't DenseVector implement equals like SparseVector does?

3. VectorView doesn't appear to implement asFormatString consistently  
with the other Vectors.  Adding:
private static void doTestVectors(Vector left, Vector right) {
     left.setQuick(0, 1);
     left.setQuick(1, 2);
     left.setQuick(2, 3);
     right.setQuick(0, 4);
     right.setQuick(1, 5);
     right.setQuick(2, 6);
     double result = left.dot(right);
     assertEquals(result + " does not equal: " + 32, 32.0, result);
     String formattedString = left.asFormatString();
     System.out.println("Vec: " + formattedString);
     Vector vec = AbstractVector.decodeVector(formattedString);
     assertTrue("vec is null and it shouldn't be", vec != null);
     assertTrue("Vector could not be decoded from the formatString",  
vec.equals(left));
   }

to VectorTest causes a failure for the VectorView test stuff.   
Shouldn't it output the format in a manner consistent with the  
underlying implementation?  Thus, if it is a DenseVector, then it  
outputs that type, else if it is a Sparse it outputs the sparse type.

Thoughts?

-Grant