Return-Path: Delivered-To: apmail-lucene-mahout-dev-archive@locus.apache.org Received: (qmail 41147 invoked from network); 8 Nov 2008 15:13:35 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 Nov 2008 15:13:35 -0000 Received: (qmail 48076 invoked by uid 500); 8 Nov 2008 15:13:42 -0000 Delivered-To: apmail-lucene-mahout-dev-archive@lucene.apache.org Received: (qmail 48040 invoked by uid 500); 8 Nov 2008 15:13:42 -0000 Mailing-List: contact mahout-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mahout-dev@lucene.apache.org Delivered-To: mailing list mahout-dev@lucene.apache.org Received: (qmail 48029 invoked by uid 99); 8 Nov 2008 15:13:42 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 Nov 2008 07:13:42 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 Nov 2008 15:12:32 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id D5816234C25E for ; Sat, 8 Nov 2008 07:12:44 -0800 (PST) Message-ID: <1680705380.1226157164873.JavaMail.jira@brutus> Date: Sat, 8 Nov 2008 07:12:44 -0800 (PST) From: "Sean Owen (JIRA)" To: mahout-dev@lucene.apache.org Subject: [jira] Commented: (MAHOUT-95) UserSimilarity-based NearestNNeighborhood In-Reply-To: <1200534965.1226081094787.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/MAHOUT-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645989#action_12645989 ] Sean Owen commented on MAHOUT-95: --------------------------------- Looks OK to me. I agree it makes sense to maintain only 1 class if it encapsulates the other two. I changed the original today so you may want to look at the original again. > UserSimilarity-based NearestNNeighborhood > ----------------------------------------- > > Key: MAHOUT-95 > URL: https://issues.apache.org/jira/browse/MAHOUT-95 > Project: Mahout > Issue Type: Improvement > Components: Collaborative Filtering > Reporter: Otis Gospodnetic > Priority: Minor > Attachments: MAHOUT-95-diff-against-nearestN.txt, MAHOUT-95.patch > > > A variation of NearestNUserNeighborhood. This version adds the minSimilarity parameter, which is the primary factor for including/excluding other users from the target user's neighbourhood. Additionally, the 'n' parameter was renamed to maxHoodSize and is used to optionally limit the size of the neighbourhood. > The patch is for a brand new class, but we may really want just a single class (either keep this one and axe NearestNUserNeighborhood or add this functionality to NearestNUserNeighborhood), if this sounds good. > I'll update the unit test and provide a patch for that if others think this can go in. > Thoughts? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.