Mailing-List: contact mahout-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mahout-dev@lucene.apache.org
Received-SPF: pass (athena.apache.org: domain of srowen@gmail.com designates
 74.125.46.28 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=C+1YDxM6vaT2Dtq5gnCQ45vH+9XDX+cukEVEF6FetSeF7BlKliU35OYnRbrJim4nQW
         tHKl1sO53mJY2ZkAVKTrzMyZtULwZH76qosA4dzgxJm2gWkmyWqGj+NtoiGVkCKh5y/b
         k6tJlDmLFi7I9/0RdR5amr2+PTgFlk4sq2uq8=
Message-ID: <e2e029610808071447n19011f05lb2189eec89e61ed7@mail.gmail.com>
Date: Thu, 7 Aug 2008 17:47:16 -0400
From: "Sean Owen" <srowen@gmail.com>
To: mahout-dev@lucene.apache.org
Subject: Re: asFormatString tests fail
In-Reply-To: <5c24dcc30808071232u25d2ca66u9bc9fe685471a791@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <5c24dcc30808071232u25d2ca66u9bc9fe685471a791@mail.gmail.com>

Yeah that Map is a HashMap and so has no predictable key ordering.

Sounds like we want a TreeMap (i.e. a SortedMap implementation)?
author, may I change it? :)

On Thu, Aug 7, 2008 at 3:32 PM, Allen Day <allenday@gmail.com> wrote:
> Here's a relevant snippet:
>
>    [junit] Testcase:
> testAsFormatString(org.apache.mahout.matrix.TestSparseVector):
> FAILED
>    [junit] format expected:<[s5, [2:2.2, 1:1.1], 3:3.3, ] > but
> was:<[s5, [1:1.1, 2:2.2], 3:3.3, ] >
>    [junit] junit.framework.ComparisonFailure: format expected:<[s5,
> [2:2.2, 1:1.1], 3:3.3, ] > but was:<[s5, [1:1.1, 2:2.2], 3:3.3, ] >
>    [junit]     at
> org.apache.mahout.matrix.TestSparseVector.testAsFormatString(TestSparseVector.java:40)
>
> I've seen this happen in some of my dev environments but not others.
> The error is because the serialized vector/matrix has transposed some
> of the elements relative to what the unit test expects.  It looks to
> me like this is caused by iterating over the keyset directly rather
> than sorting it first:
>
> SparseVector.java:97
> -------------------------
>  public String asFormatString() {
>    StringBuilder out = new StringBuilder();
>    out.append("[s").append(cardinality).append(", ");
>    for (Integer index : values.keySet())
>      out.append(index).append(':').append(values.get(index)).append(", ");
>    out.append("] ");
>    return out.toString();
>  }
> -------------------------
>
> -Allen
>