mahout-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Owen (JIRA)" <>
Subject [jira] Updated: (MAHOUT-25) Minor bugs/issues from code inspection
Date Fri, 18 Apr 2008 01:17:21 GMT


Sean Owen updated MAHOUT-25:

    Attachment: MAHOUT-25.patch

OK I'll only try this once. Here's a collection of small tweaks to the code that I would suggest.
Everything compiles and unit tests pass. I am happy to be talked out of this, but thought
I would offer it, as it does standardize the code a bit.

> Minor bugs/issues from code inspection
> --------------------------------------
>                 Key: MAHOUT-25
>                 URL:
>             Project: Mahout
>          Issue Type: Bug
>          Components: Matrix
>    Affects Versions: 0.1
>         Environment: All
>            Reporter: Sean Owen
>            Priority: Minor
>             Fix For: 0.1
>         Attachments: MAHOUT-25.patch
> Hi all, just started checking out the code base to get familiar with it and turned loose
IntelliJ on the code. It picked up a few possible issues I thought I'd highlight:
> MatrixView:57
>       for (int col = offset[COL]; col < offset[COL] + cardinality[COL]; row++)
> Pretty sure that should be col++ at the end.
> DenseMatrix:122
> Instances are compared uisng == instead of equals(). Doesn't matter if this is exactly
the semantics you want, but if DenseMatrix ever defined a notion of equals() this wouldn't
use it and might be a bug. Same in many other classes.
> Canopy:146, 168
>       pointStronglyBound = pointStronglyBound | (dist < t2);
> Should this really be a non-shortcircuit, versus
>        pointStronglyBound = pointStronglyBound || (dist < t2);
> or just
>        if (!pointStronglyBound) {
>               pointStronglyBound = dist < t2;
>        }
> CanopyDriver:52,53
> String.valueOf(x) is a smidge faster than "" + x.
> Actually I've got several more but they're less important, like redundant casts or utility
classes without private constructors, etc. I can keep going here... want to help polish a
few things but don't want to get overbearing.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message