Return-Path: X-Original-To: apmail-mahout-commits-archive@www.apache.org Delivered-To: apmail-mahout-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B35711157A for ; Thu, 3 Jul 2014 20:37:40 +0000 (UTC) Received: (qmail 45123 invoked by uid 500); 3 Jul 2014 20:37:40 -0000 Delivered-To: apmail-mahout-commits-archive@mahout.apache.org Received: (qmail 45066 invoked by uid 500); 3 Jul 2014 20:37:40 -0000 Mailing-List: contact commits-help@mahout.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mahout.apache.org Delivered-To: mailing list commits@mahout.apache.org Received: (qmail 45051 invoked by uid 99); 3 Jul 2014 20:37:40 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jul 2014 20:37:40 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jul 2014 20:37:41 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id E521A238890D; Thu, 3 Jul 2014 20:37:16 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1607745 - /mahout/site/mahout_cms/trunk/content/developers/how-to-contribute.mdtext Date: Thu, 03 Jul 2014 20:37:16 -0000 To: commits@mahout.apache.org From: apalumbo@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20140703203716.E521A238890D@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: apalumbo Date: Thu Jul 3 20:37:16 2014 New Revision: 1607745 URL: http://svn.apache.org/r1607745 Log: MAHOUT-1587 Update website to reflect move to GitHub -- quick edit Modified: mahout/site/mahout_cms/trunk/content/developers/how-to-contribute.mdtext Modified: mahout/site/mahout_cms/trunk/content/developers/how-to-contribute.mdtext URL: http://svn.apache.org/viewvc/mahout/site/mahout_cms/trunk/content/developers/how-to-contribute.mdtext?rev=1607745&r1=1607744&r2=1607745&view=diff ============================================================================== --- mahout/site/mahout_cms/trunk/content/developers/how-to-contribute.mdtext (original) +++ mahout/site/mahout_cms/trunk/content/developers/how-to-contribute.mdtext Thu Jul 3 20:37:16 2014 @@ -108,7 +108,7 @@ incorporate other's suggestions into int #### Unit Tests -Please make sure that all unit tests succeed before creating your pull request. +Please make sure that all unit tests succeed before creating your Pull Request. Run *mvn clean test*, if you see *BUILD SUCCESSFUL* after the tests have finished, all is ok, but if you see *BUILD FAILED*, please carefully read the errors messages and check your code. @@ -135,7 +135,7 @@ Please do: ## Review/Improve Existing Pull Requests If there's a JIRA issue that already has a Pull Request with changes that you think are really good, and works well for you -- please add a comment saying so. If there's room -for improvement (more tests, better javadocs, etc...) then make the changes and add a comment about them. If a lot of people review a Pull Request and give it a +for improvement (more tests, better javadocs, etc...) then make the changes on your GitHub branch and add a comment about them. If a lot of people review a Pull Request and give it a thumbs up, that's a good sign for committers when deciding if it's worth spending time to review it -- and if other people have already put in effort to improve the docs/tests for an issue, that helps even more.