mahout-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From apalu...@apache.org
Subject svn commit: r1607745 - /mahout/site/mahout_cms/trunk/content/developers/how-to-contribute.mdtext
Date Thu, 03 Jul 2014 20:37:16 GMT
Author: apalumbo
Date: Thu Jul  3 20:37:16 2014
New Revision: 1607745

URL: http://svn.apache.org/r1607745
Log:
    MAHOUT-1587  Update website to reflect move to GitHub -- quick edit

Modified:
    mahout/site/mahout_cms/trunk/content/developers/how-to-contribute.mdtext

Modified: mahout/site/mahout_cms/trunk/content/developers/how-to-contribute.mdtext
URL: http://svn.apache.org/viewvc/mahout/site/mahout_cms/trunk/content/developers/how-to-contribute.mdtext?rev=1607745&r1=1607744&r2=1607745&view=diff
==============================================================================
--- mahout/site/mahout_cms/trunk/content/developers/how-to-contribute.mdtext (original)
+++ mahout/site/mahout_cms/trunk/content/developers/how-to-contribute.mdtext Thu Jul  3 20:37:16
2014
@@ -108,7 +108,7 @@ incorporate other's suggestions into int
 <a name="HowToContribute-UnitTests"></a>
 #### Unit Tests
 
-Please make sure that all unit tests succeed before creating your pull request.
+Please make sure that all unit tests succeed before creating your Pull Request.
 
 Run *mvn clean test*, if you see *BUILD SUCCESSFUL* after the tests have finished, all is
ok, but if you see *BUILD FAILED*, 
 please carefully read the errors messages and check your code.
@@ -135,7 +135,7 @@ Please do:
 ## Review/Improve Existing Pull Requests
 
 If there's a JIRA issue that already has a Pull Request with changes that you think are really
good, and works well for you -- please add a comment saying so.   If there's room
-for improvement (more tests, better javadocs, etc...) then make the changes and add a comment
about them.	If a lot of people review a Pull Request and give it a
+for improvement (more tests, better javadocs, etc...) then make the changes on your GitHub
branch and add a comment about them.	If a lot of people review a Pull Request and give it
a
 thumbs up, that's a good sign for committers when deciding if it's worth spending time to
review it -- and if other people have already put in
 effort to improve the docs/tests for an issue, that helps even more.
 



Mime
View raw message