mahout-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sro...@apache.org
Subject svn commit: r1000727 - /mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/eval/AbstractDifferenceRecommenderEvaluator.java
Date Fri, 24 Sep 2010 06:39:39 GMT
Author: srowen
Date: Fri Sep 24 06:39:39 2010
New Revision: 1000727

URL: http://svn.apache.org/viewvc?rev=1000727&view=rev
Log:
Remove unneeded and possibly problematic isDone()

Modified:
    mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/eval/AbstractDifferenceRecommenderEvaluator.java

Modified: mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/eval/AbstractDifferenceRecommenderEvaluator.java
URL: http://svn.apache.org/viewvc/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/eval/AbstractDifferenceRecommenderEvaluator.java?rev=1000727&r1=1000726&r2=1000727&view=diff
==============================================================================
--- mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/eval/AbstractDifferenceRecommenderEvaluator.java
(original)
+++ mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/eval/AbstractDifferenceRecommenderEvaluator.java
Fri Sep 24 06:39:39 2010
@@ -193,15 +193,12 @@ abstract class AbstractDifferenceRecomme
     callables = wrapWithStatsCallables(callables, noEstimateCounter);
     int numProcessors = Runtime.getRuntime().availableProcessors();
     ExecutorService executor = Executors.newFixedThreadPool(numProcessors);
-    log.info("Starting timing of {} tasks in {} threads", callables
-        .size(), numProcessors);
+    log.info("Starting timing of {} tasks in {} threads", callables.size(), numProcessors);
     try {
       List<Future<Void>> futures = executor.invokeAll(callables);
       // Go look for exceptions here, really
       for (Future<Void> future : futures) {
-        if (!future.isDone()) {
-          future.get();
-        }
+        future.get();
       }
     } catch (InterruptedException ie) {
       throw new TasteException(ie);



Mime
View raw message