Return-Path: Delivered-To: apmail-mahout-commits-archive@www.apache.org Received: (qmail 31048 invoked from network); 13 Jun 2010 15:34:42 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 13 Jun 2010 15:34:42 -0000 Received: (qmail 34252 invoked by uid 500); 13 Jun 2010 15:34:42 -0000 Delivered-To: apmail-mahout-commits-archive@mahout.apache.org Received: (qmail 34151 invoked by uid 500); 13 Jun 2010 15:34:41 -0000 Mailing-List: contact commits-help@mahout.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mahout.apache.org Delivered-To: mailing list commits@mahout.apache.org Received: (qmail 34144 invoked by uid 99); 13 Jun 2010 15:34:41 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 13 Jun 2010 15:34:41 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 13 Jun 2010 15:34:39 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id BFDC623889B3; Sun, 13 Jun 2010 15:33:56 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r954243 - /mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/model/MySQLJDBCIDMigrator.java Date: Sun, 13 Jun 2010 15:33:56 -0000 To: commits@mahout.apache.org From: srowen@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100613153356.BFDC623889B3@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: srowen Date: Sun Jun 13 15:33:56 2010 New Revision: 954243 URL: http://svn.apache.org/viewvc?rev=954243&view=rev Log: INSERT IGNORE more sensible and faster than REPLACE INTO to handle possible duplicates Modified: mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/model/MySQLJDBCIDMigrator.java Modified: mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/model/MySQLJDBCIDMigrator.java URL: http://svn.apache.org/viewvc/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/model/MySQLJDBCIDMigrator.java?rev=954243&r1=954242&r2=954243&view=diff ============================================================================== --- mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/model/MySQLJDBCIDMigrator.java (original) +++ mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/model/MySQLJDBCIDMigrator.java Sun Jun 13 15:33:56 2010 @@ -28,9 +28,8 @@ import javax.sql.DataSource; * * 
  * CREATE TABLE taste_id_migration (
- *   long_id BIGINT NOT NULL,
- *   string_id VARCHAR(255) NOT NULL,
- *   PRIMARY KEY (long_id)
+ *   long_id BIGINT NOT NULL PRIMARY KEY,
+ *   string_id VARCHAR(255) NOT NULL UNIQUE
  * )
  *
* @@ -60,8 +59,9 @@ public final class MySQLJDBCIDMigrator e String mappingTable, String longIDColumn, String stringIDColumn) { - super(dataSource, "SELECT " + stringIDColumn + " FROM " + mappingTable + " WHERE " + longIDColumn + "=?", - "REPLACE INTO " + mappingTable + " (" + longIDColumn + ',' + stringIDColumn + ") VALUES (?,?)"); + super(dataSource, + "SELECT " + stringIDColumn + " FROM " + mappingTable + " WHERE " + longIDColumn + "=?", + "INSERT IGNORE INTO " + mappingTable + " (" + longIDColumn + ',' + stringIDColumn + ") VALUES (?,?)"); } } \ No newline at end of file