Return-Path: Delivered-To: apmail-lucene-mahout-commits-archive@minotaur.apache.org Received: (qmail 23445 invoked from network); 8 Mar 2009 18:00:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 Mar 2009 18:00:45 -0000 Received: (qmail 74686 invoked by uid 500); 8 Mar 2009 18:00:45 -0000 Delivered-To: apmail-lucene-mahout-commits-archive@lucene.apache.org Received: (qmail 74658 invoked by uid 500); 8 Mar 2009 18:00:45 -0000 Mailing-List: contact mahout-commits-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mahout-dev@lucene.apache.org Delivered-To: mailing list mahout-commits@lucene.apache.org Received: (qmail 74649 invoked by uid 99); 8 Mar 2009 18:00:45 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Mar 2009 11:00:45 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Mar 2009 18:00:44 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 399FE2388A16; Sun, 8 Mar 2009 18:00:24 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r751485 - /lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/slopeone/MemoryDiffStorage.java Date: Sun, 08 Mar 2009 18:00:24 -0000 To: mahout-commits@lucene.apache.org From: srowen@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090308180024.399FE2388A16@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: srowen Date: Sun Mar 8 18:00:23 2009 New Revision: 751485 URL: http://svn.apache.org/viewvc?rev=751485&view=rev Log: Enable new speedup for slope one that excludes items from consideration that can never be recommended since they don't co-occur with another item Modified: lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/slopeone/MemoryDiffStorage.java Modified: lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/slopeone/MemoryDiffStorage.java URL: http://svn.apache.org/viewvc/lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/slopeone/MemoryDiffStorage.java?rev=751485&r1=751484&r2=751485&view=diff ============================================================================== --- lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/slopeone/MemoryDiffStorage.java (original) +++ lucene/mahout/trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/slopeone/MemoryDiffStorage.java Sun Mar 8 18:00:23 2009 @@ -204,25 +204,14 @@ @Override public Set getRecommendableItems(Object userID) throws TasteException { User user = dataModel.getUser(userID); - Set result = new FastSet(dataModel.getNumItems()); - for (Item item : dataModel.getItems()) { - // If not already preferred by the user, add it - if (user.getPreferenceFor(item.getID()) == null) { - result.add(item); - } - } - return result; - /* - User user = dataModel.getUser(userID); Set result = allRecommendableItemIDs.clone(); Iterator it = result.iterator(); while (it.hasNext()) { - if (user.getPreferenceFor(it.next().getID()) == null) { + if (user.getPreferenceFor(it.next().getID()) != null) { it.remove(); } } return result; - */ } private void buildAverageDiffs() throws TasteException {