lucy-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Logan Bell (Assigned) (JIRA)" <j...@apache.org>
Subject [lucy-issues] [jira] [Assigned] (LUCY-148) Mix declarations and code
Date Fri, 16 Dec 2011 21:08:31 GMT

     [ https://issues.apache.org/jira/browse/LUCY-148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Logan Bell reassigned LUCY-148:
-------------------------------

    Assignee: Logan Bell
    
> Mix declarations and code
> -------------------------
>
>                 Key: LUCY-148
>                 URL: https://issues.apache.org/jira/browse/LUCY-148
>             Project: Lucy
>          Issue Type: Sub-task
>            Reporter: Marvin Humphrey
>            Assignee: Logan Bell
>            Priority: Minor
>         Attachments: c99_patch01.patch, c99_patch02.patch, c99_patch03.patch, c99_patch04.patch,
c99_patch05.patch
>
>
> Much of Lucy was originally written for C89, and uses the C89 idiom of
> declaring all variables at the top of a scope and then assigning to them
> later.  Often, this is not ideal code layout, and it would be clearer to
> declare the variable at the same time as it is initialized to a value.
> The following command will reveal many candidates for review.
> {noformat}
> $ grep -r "^ \+[A-Za-z_0-9]\+[ *]\+[a-z0-9_]\+[;,]" lucy \
> > | grep -v "\<return\>" \
> > | grep -v -e "svn\|charmonizer\|modules\|\.pm"
> {noformat}
> LUCY-146 can be considered a specific case of this issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message