lucy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nwellnhof <>
Subject [lucy-dev] [GitHub] lucy-clownfish pull request: String API
Date Wed, 28 Oct 2015 15:14:10 GMT
GitHub user nwellnhof opened a pull request:

    String API

    Clean up the String API, as discussed on lucy-dev.
    * I didn't remove `Str_Cat_Utf8`.
    * I didn't change `StrIter_Starts_With`.

You can merge this pull request into a Git repository by running:

    $ git pull string-api

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #40
commit e0d83010bdb9ce4159893fb117c7c6bf15c6cae8
Author: Marvin Humphrey <>
Date:   2015-10-22T13:24:44Z

    Doc tweaks for String classes

commit f09709361e96ee018a2851f43b982c3323e0b656
Author: Nick Wellnhofer <>
Date:   2015-10-22T13:27:30Z

    Rename new_stack_string to init_stack_string
    This function doesn't allocate memory.

commit 0bfc3498832d06468a337fe554de52ab631ebf6e
Author: Nick Wellnhofer <>
Date:   2015-10-22T13:36:53Z

    Remove Str_Swap_Chars
    Only used once in Lucy. A method to replace whole strings would be more

commit 77d6dfd6dae2d60be0424adfa82a197c769ab95d
Author: Nick Wellnhofer <>
Date:   2015-10-22T13:46:42Z

    Change Code_Point_{At|From} return value
    Make Code_Point_{At|From} return STR_OOB (-1) instead of 0 if the tick
    is out of bounds. This allows to process strings containing U+0000.

commit 8b5f8dbe7934c5f22372573b11acb75255541661
Author: Nick Wellnhofer <>
Date:   2015-10-22T13:52:10Z

    Remove Str_compare and Str_less_than

commit 86a6c98560e45e37201ef14aac74c114c628378f
Author: Nick Wellnhofer <>
Date:   2015-10-22T13:57:56Z

    Rename Ends_With argument from postfix to suffix

commit caab9f0d953f681d5bb5654eb2f9d681159f3d8f
Author: Nick Wellnhofer <>
Date:   2015-10-22T14:00:31Z

    Mark Str_Trim return value as incremented

commit f126bf31a299968a7595512f859c1e8c7727a8cb
Author: Nick Wellnhofer <>
Date:   2015-10-22T14:05:35Z

    Make most String functions and methods public

commit 2f6b2393c84402b296b3081265f64c350529e96f
Author: Nick Wellnhofer <>
Date:   2015-10-24T13:14:59Z

    Rework Str_Find interface
    Make Str_Find return a StringIterator. Add Str_Contains.
    Optimize substring search to use memchr. Unfortunately, memmem isn't
    widely available.

commit 4ea023cb6faeafca6d0e89f9c9b211aa08552e9a
Author: Nick Wellnhofer <>
Date:   2015-10-24T13:38:01Z

    Rename Skip_{Next|Prev}_Whitesapce
    Rename Skip_Next_Whitespace to Skip_Whitespace, Skip_Prev_Whitespace
    to Skip_Whitespace_Back.

commit 6fadaae2b17c776dac6387147b7d3d8c64f982d2
Author: Nick Wellnhofer <>
Date:   2015-10-24T14:03:23Z

    New stack string macro SSTR_WRAP_C
    Creates a stack string from a null-terminated C string. Also useful for
    string literals. (strlen of a literal should be constant folded by the

commit 16a4270cdcde34085954e2a26f29f03c3bb2ec0d
Author: Nick Wellnhofer <>
Date:   2015-10-24T14:58:51Z

    Return STR_OOB if string iterator is done
    Returning STR_OOB instead of STRITER_DONE aligns better with

commit 43312f9de56eef53d5d67a26203e5d06f8e9e824
Author: Nick Wellnhofer <>
Date:   2015-10-24T16:16:47Z

    Remove StrIter assertions
    With immutable strings, the StrIter byte offset should always be within

commit 795778809346ae2cb0743fd543c5f1338d1b308e
Author: Nick Wellnhofer <>
Date:   2015-10-28T14:38:33Z

    Rename StrIter_substring to StrIter_crop


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message