lucy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rectang <>
Subject [lucy-dev] [GitHub] lucy-clownfish pull request: CLOWNFISH-61 Run core tests under Go
Date Thu, 01 Oct 2015 01:58:46 GMT
GitHub user rectang opened a pull request:

    CLOWNFISH-61 Run core tests under Go

    Run the core tests under the Go bindings.
    Some kludges are necessary to suppress failures in Err, whose usage of thread-local storage
is not compatible with Go's concurrency model.

You can merge this pull request into a Git repository by running:

    $ git pull CLOWNFISH-61-core-tests-under-go

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #39
commit 1697a39c8167d7ff82c8123bef72d4f457bd6595
Author: Marvin Humphrey <>
Date:   2015-10-01T01:44:59Z

    Disable thread support under Go.
    Err's design relies on thread-local storage, which is not compatible
    with Go's goroutines.  Resolving the Clownfish and Go concurrency models
    is left as a TODO.

commit 276f924e76a7d82420637cb5d5476a7a16283a65
Author: Marvin Humphrey <>
Date:   2015-10-01T01:47:02Z

    Stub out some TestUtils funcs under Go.
    Create stub implementations for some functions that are required for
    running the core tests.

commit fe2d3b63c92dc70cb97ed650b613df089005a46c
Author: Marvin Humphrey <>
Date:   2015-10-01T01:52:39Z

    Run core tests under Go.


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message