lucy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marvin Humphrey <mar...@rectangular.com>
Subject Re: [lucy-dev] [GitHub] lucy-clownfish pull request: Rework Perl SV to Clownfish object co...
Date Wed, 09 Sep 2015 00:49:26 GMT
On Thu, Aug 20, 2015 at 11:16 AM, nwellnhof <git@git.apache.org> wrote:
> GitHub user nwellnhof opened a pull request:
>
>     https://github.com/apache/lucy-clownfish/pull/36
>
>     Rework Perl SV to Clownfish object conversion

I reviewed this, finally.  Changing up both refcounts and nulls is
really tricky, but I looked at each call site in both Clownfish and
Lucy and I couldn't find any mistakes.  Yowza!

I'm a little surprised that we didn't need the combination of nullable
and noinc.  But it's rare and can be faked by with nullable conversion
followed by a DECREF.

Marvin Humphrey

Mime
View raw message