Mailing-List: contact dev-help@lucy.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucy.apache.org
Received-SPF: neutral (nike.apache.org: local policy)
Message-ID: <516BD17D.5070109@aevum.de>
Date: Mon, 15 Apr 2013 12:07:57 +0200
From: Nick Wellnhofer <wellnhofer@aevum.de>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/20130328 Thunderbird/17.0.5
MIME-Version: 1.0
To: dev@lucy.apache.org
References: 
 <CAAS6=7jFr+XNcvi=VsWpOnK7_D9jXuh2eS6nf15uzObXB1BrxQ@mail.gmail.com>
 <7D60D702-3184-4B00-8F1B-D1308490E180@aevum.de>
 <CAAS6=7hevY+F4qj40o7uZm-6EqQwDDTnF=7oaV_JqZbbvOZ9uQ@mail.gmail.com>
In-Reply-To: 
 <CAAS6=7hevY+F4qj40o7uZm-6EqQwDDTnF=7oaV_JqZbbvOZ9uQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [lucy-dev] Initial sketch of string iterators

On 14/04/2013 04:25, Marvin Humphrey wrote:
> Good point.  How about a symbolic value, `DONE`, or in full,
> `CFISH_CBITER_DONE` and eventually also `CFISH_STRITER_DONE`?

+1

>> After reaching the end of the string, I can see two options which both have
>> their pros and cons:
>>
>>      * Change to a new iterator state ("beyond string boundary") and throw
>>        an exception on every subsequent access (like in your example below).
>>      * Keep returning the sentinel value on calls to Next() but allow to
>>        move backward via Prev(). This can result in an infinite loop in
>>        faulty code.
>
> I don't have a strong opinion.

I lean towards the second option.

> What do you think of putting a flag into CharBuf/String which indicates how it
> should deallocated?
>
>      void
>      CB_destroy(CharBuf *self) {
>          if (!(self->flags & CB_HEAP_ALLOCATED)) {
>              THROW(ERR, "Can't Destroy non-heap-allocated CharBuf");
>          }
>          ...
>      }
>
> That would allow us to get rid of the Zombie classes.  Rationale: using
> subclassing to control memory allocation is odd, plus the name "Zombie" isn't
> the greatest.

I think it's a good idea but I wouldn't want to waste a whole word in 
the CharBuf struct just for a single flag.

Nick