lucy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marvin Humphrey <mar...@rectangular.com>
Subject [lucy-dev] Re: [lucy-issues] [jira] [Updated] (LUCY-215) Support extensions written in C
Date Tue, 10 Apr 2012 21:47:26 GMT
On Tue, Apr 10, 2012 at 12:35 PM, Nick Wellnhofer (Updated) (JIRA)
<jira@apache.org> wrote:

>    Attachment: 0019-LUCY-215-Add-autogen-source-directly-to-CF-build-sou.patch
>                0018-LUCY-215-Supply-some-build-params-via-Lucy-Build-con.patch
>                0017-LUCY-215-Add-C-C-P-B-cf_base_path.patch
>                0016-LUCY-215-Introduce-C-C-P-B-cf_copy_include.patch
>
> Patches up to 0015 are now committed to trunk including changes that were discussed on
lucy-dev.

There's a lot of great work going on here!

> Here are some additional patches 0016 - 0019 that I'd like to add on top of
> my previous work.

+1 to commit all of them.

The cf_copy_include patch (#16) is a particularly nice way to solve that
problem.  I agree with having the user be explicit about installing anything
other than a .cfh file.  I wondered for a bit about throwing an exception if
the file can't be found, but then I realized that the three files Lucy uses
this method to install are absolutely mandatory, so that's probably the right
behavior.

I also felt good about #19, the patch that automatically adds autogen/source.
Smart move -- that definitely shouldn't be the user's responsibility.

Marvin Humphrey

Mime
View raw message