lucy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Wellnhofer <>
Subject Re: [lucy-dev] Build support classes for C extensions
Date Sat, 07 Apr 2012 14:38:15 GMT
On 07/04/2012 04:15, Marvin Humphrey wrote:
> Can we still consolidate "core_source_dir" and "extra_c_sources" into
> a single "source" param?

Yes, that's possible. Basically, the only side effect is that all the 
extra C source dirs will be scanned for .cfh files, but that shouldn't 
be a problem.

> +1 to keep dist_version().  Both you and David Wheeler have suggested it
> independently.  I'm persuaded.
> In addition, we should apply the patch below my sig, which changes
> XSLoader::load to use the same X.Y.Z version format that we supply as the
> dist_version argument to the Lucy::Build constructor.

OK, I'll add the patch.


View raw message