Mailing-List: contact lucy-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: lucy-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: local policy)
Date: Wed, 21 Dec 2011 21:15:56 -0800
From: Marvin Humphrey <marvin@rectangular.com>
To: lucy-dev@incubator.apache.org
Message-ID: <20111222051556.GA15440@rectangular.com>
References: <20111220220532.A7C4023888CD@eris.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20111220220532.A7C4023888CD@eris.apache.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Subject: [lucy-dev] Re: [lucy-commits] svn commit: r1221503 - in
	/incubator/lucy/trunk: core/Lucy/Analysis/EasyAnalyzer.c
	core/Lucy/Analysis/EasyAnalyzer.cfh perl/MANIFEST
	perl/lib/Lucy/Analysis/EasyAnalyzer.pm
	perl/t/binding/159-easyanalyzer.t

On Tue, Dec 20, 2011 at 10:05:32PM -0000, nwellnhof@apache.org wrote:
> Author: nwellnhof
> Date: Tue Dec 20 22:05:31 2011
> New Revision: 1221503
> 
> URL: http://svn.apache.org/viewvc?rev=1221503&view=rev
> Log:
> Implement EasyAnalyzer
> 
> A PolyAnalyzer consisting of a StandardTokenizer, a Normalizer, and a
> SnowballStemmer.

Yeeha!  Looks great!

Can you please create a JIRA issue for this, Nick?  The reason is that our
CHANGES file is a list of JIRA issues, and we want people to be able to see
that EasyAnalyzer was added in 0.3.0 and get a link to an explanation.

One thought: We may not want to have EasyAnalyzer inherit from PolyAnalyzer.
It's fine, because it works for now... but how about we at least override
Dump/Load to store only "_class" and "language"?  If we refactor the
Analyzer chain, PolyAnalyzer, since it allows *any* Analyzer to be first --
not just a Tokenizer -- may not survive the refactoring in its current
form.

Marvin Humphrey