Mailing-List: contact lucy-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: lucy-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: local policy)
Date: Sun, 1 May 2011 19:13:30 -0700
From: Marvin Humphrey <marvin@rectangular.com>
To: lucy-dev@incubator.apache.org
Message-ID: <20110502021330.GA29094@rectangular.com>
References: <20110409034321.GA15012@rectangular.com>
 <BANLkTimseHK4iVqO3Rud9GUpGh+CjrbJ+w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <BANLkTimseHK4iVqO3Rud9GUpGh+CjrbJ+w@mail.gmail.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Subject: Re: [lucy-dev] C code formatter

On Fri, Apr 08, 2011 at 10:38:56PM -0700, Nathan Kurz wrote:
> If "--add-brackets" is compatible with "--keep-one-line-statements",
> I'd love if it could be added as well.

While figuring out how to work around some of AStyle's bugs and quirks, I've
come to understand that it is not that sophisticated at C parsing.  Some of
the hacks I put in to defeat AStyle idiosyncrasies involve blatant C syntax
errors.

With that in mind, I would prefer to keep "--add-brackets" out of the astylerc
file, so that AStyle's scope is limited to whitespace only.  It has a decent
rep for not destroying your code, but I'd prefer to play it conservative.

Nevertheless, as part of LUCY-141, I ran autoformatting with "--add-brackets"
enabled, carefully checked the output and committed the change.  We could
conceivably do that again -- I'd just like to make sure that AStyle's work
gets supervised properly.

Marvin Humphrey