lucy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Karman <pe...@peknet.com>
Subject Re: [lucy-dev] [VOTE] Apache Lucy 0.1.0-incubating release candidate #3
Date Tue, 24 May 2011 02:04:43 GMT
Marvin Humphrey wrote on 5/23/11 2:41 PM:
> On Mon, May 23, 2011 at 10:56:11AM -0500, Peter Karman wrote:
>> In file included from xs/XSBind.c:19:
>>
>> xs/XSBind.h:226:13: warning: missing terminating ' character
>>
>> xs/XSBind.h:232:13: warning: missing terminating ' character
> 
> That's the #error line in this block:
>     
>     #if (CHY_SIZEOF_CHAR == 1)
>       #define XSBIND_WANT_CHAR XSBIND_WANT_I8
>     #else
>       #error Can't build unless sizeof(char) == 1
>     #endif
> 
> The message should probably be double-quoted.
> 

done in r1126821.

> 
> This is our first release.  Nobody has any CPAN dependency chains that are
> going to break because Lucy starts failing.  And sloppy code can actually be
> good for a project.  (There's some Apache aphorism to the tune of "bad code
> plus good people equals successful project" that I'm unable to recall just
> this moment.)

+1 to that.

it's just one more step on the road to 0.2.0! :)

My original +1 for RC3 stands.


-- 
Peter Karman  .  http://peknet.com/  .  peter@peknet.com

Mime
View raw message