Return-Path: X-Original-To: apmail-lucenenet-user-archive@www.apache.org Delivered-To: apmail-lucenenet-user-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3F5DB179D5 for ; Mon, 13 Apr 2015 21:15:32 +0000 (UTC) Received: (qmail 80718 invoked by uid 500); 13 Apr 2015 21:15:32 -0000 Delivered-To: apmail-lucenenet-user-archive@lucenenet.apache.org Received: (qmail 80685 invoked by uid 500); 13 Apr 2015 21:15:32 -0000 Mailing-List: contact user-help@lucenenet.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@lucenenet.apache.org Delivered-To: mailing list user@lucenenet.apache.org Received: (qmail 80672 invoked by uid 99); 13 Apr 2015 21:15:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Apr 2015 21:15:31 +0000 X-ASF-Spam-Status: No, hits=2.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS,TVD_FROM_1 X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of itamar.synhershko@gmail.com designates 209.85.218.52 as permitted sender) Received: from [209.85.218.52] (HELO mail-oi0-f52.google.com) (209.85.218.52) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Apr 2015 21:15:06 +0000 Received: by oift201 with SMTP id t201so14682758oif.3 for ; Mon, 13 Apr 2015 14:15:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=EtyPLOOu3+kPKj7NQPUuapLwFbzDZt5dWsMP0He3/zc=; b=NlqncZJ6U1hjrinK47abwpHHrqjanHL7tIimaNLMYTS3IvWkgV7X3zMNnxaOeOmiWx s4/alLkyWwMm/4lVOe3x6fLwvPtnYaPF3J1EtyNGpS8c5KTjCJP15ca0ERFxh266JYOX QYMSPF+qc5mN5I9MA5HiDCfmiziYXdOine5mlxDEvqLqTyCrrlr1bPrRKQhrtrstnyWQ uCj6sn/WM4pv0OvatLDqU6AH4n/3wIdcP48h7TWPf4eyMCfiUlM39Xxxh+5i6zY2DRBQ x40TVh4Fju2JDjIDwqWIT6VxEoKivazsQvgENoU/zOXE44TLwfDpyOwSLbfDKYlaZrIX dJGA== MIME-Version: 1.0 X-Received: by 10.202.177.212 with SMTP id a203mr8776636oif.46.1428959704731; Mon, 13 Apr 2015 14:15:04 -0700 (PDT) Sender: itamar.synhershko@gmail.com Received: by 10.60.48.100 with HTTP; Mon, 13 Apr 2015 14:15:04 -0700 (PDT) In-Reply-To: References: Date: Tue, 14 Apr 2015 00:15:04 +0300 X-Google-Sender-Auth: GhTLY61_DpyrKesprC5eua_xMj0 Message-ID: Subject: Re: Last failing tests remain to fix! From: Itamar Syn-Hershko To: user@lucenenet.apache.org Content-Type: multipart/alternative; boundary=001a113cdeac997b440513a19b95 X-Virus-Checked: Checked by ClamAV on apache.org --001a113cdeac997b440513a19b95 Content-Type: text/plain; charset=UTF-8 Hi Wade, any luck? Is there a nuget feed on the build server we can start using to install the core / subproject pieces using nuget from? Thanks! -- Itamar Syn-Hershko http://code972.com | @synhershko Freelance Developer & Consultant Lucene.NET committer and PMC member On Thu, Apr 9, 2015 at 1:53 AM, Wyatt Barnett wrote: > Yup that makes sense -- somehow I conflated sub projects over to contrib > which I haven't seen any movement. > > I'm on the road at the moment but I'll see about getting the remaining sub > projects setup and building, auditing the ignores and start banging on > nuget when I get back to the ranch. > On Apr 8, 2015 5:42 PM, "Itamar Syn-Hershko" wrote: > > > inline > > > > -- > > > > Itamar Syn-Hershko > > http://code972.com | @synhershko > > Freelance Developer & Consultant > > Lucene.NET committer and PMC member > > > > On Thu, Apr 9, 2015 at 1:09 AM, Wyatt Barnett > > wrote: > > > > > Thanks for the update Itamar -- this sounds exciting. > > > > > > A few notes / questions from the build side of things here: > > > > > > First, I'm not as hung up on persistently failing tests as the tests we > > get > > > intermittent failures on. I suspect some of the below will address > this. > > > > > > > Yup > > > > > > > > > > Second, what do we want to do about the 112 or so ignored tests? I > think > > > some are marked as long-running via the [LongRunningTest] attribute but > > > there are probably some ignored failures in that mix. > > > > > > > I guess that should be another task someone needs to take - can you try > and > > categorize them? some I know are JVM specfic tests that don't apply to > > Lucene.NET > > > > > > > > > > Third, regarding the sub-projects, what does the structure look like > so I > > > can get that integrated into the TeamCity setup? Or should I noodle on > it > > > and propose one? > > > > > > > What do you mean? See here > > https://github.com/apache/lucenenet/tree/master/src > > > > Every subproject has a test suite that needs to be run, and should > produce > > a class library that we could push to nuget when we release. Until then > we > > should be able to allow people to install via nuget from our build > server's > > feed. > > > > As far as dependencies and build triggers - that should be obvious and > self > > explanatory.. > > > > Does that make sense? > > > > > > > > > > Thanks for all the help from everyone getting things this far. > > > > > > On Wed, Apr 8, 2015 at 1:07 PM, Itamar Syn-Hershko > > > > wrote: > > > > > > > Hey all, > > > > > > > > We are nearly there -- we are this close to a release! > > > > > > > > We have only about 30 failing tests now in the core, and I'd like to > > push > > > > hard during the next few days so we can get a beta out next week. > > > > > > > > I'd appreciate your help with this! > > > > > > > > I've narrowed down several failing tests that require some digging, > if > > > > folks can assign those to themselves and send us PRs fixing those > > tests, > > > > that would help a lot! > > > > > > > > 1. Lucene.Net.Search.TestNumericRangeQuery32.TestInfiniteValues() > > > > and Lucene.Net.Search.TestNumericRangeQuery64.TestInfiniteValues() -- > > > > specifically it seems like Double and Float NaNs are treated > > differently > > > > between C# and Java and therefore the failing tests. Or there is a > bug > > in > > > > the inner implementation handling those queries. > > > > > > > > 2. TestLucene40DocValuesFormat has a few failing tests, probably > > exposing > > > > data corruption in one of the codec components. I believe this is > > > contained > > > > in the 40DocValues tests so the scope isn't huge but I could be > wrong. > > > > > > > > 3. TestLucene42DocValuesFormat has two tests failing with output of > > lines > > > > like "Fail: frozenHash=182658 vs h=5124052". Something is off in > > > computing > > > > the hashes of the nodes, or maybe the node construction is faulty > > (which > > > is > > > > a serious bug). Hashing is done in Lucene.Net.Fst.NodeHash, > that'll > > > be a > > > > good starting point. Also see > > > > > > > > > > > > > > https://github.com/apache/lucenenet/commit/ea7cfe6972972f91090d995c729689fff9a0f54c > > > > > > > > 4. There seem to be some concurrency issues with file handling, > > probably > > > on > > > > the part that is in charge of acquiring and releasing locks. In > > > particular > > > > see TestDocValuesFormat, > > > > .TestShardSearching.TestSimple(), > > > > TestBufferedIndexInput.TestSetBufferSize(), > > > > TestLockFactory.TestStressLocks(), > > > > TestLockFactory.TestStressLocksNativeFSLockFactory() > > > > > > > > 5. RegexpQuery seems to be broken, I believe the underlying automaton > > > > implementation doesn't emit the terms correctly. See the failures in > > > > TestRegexpQuery and TestRegexpRandom. > > > > > > > > 6. Similar but probably unrelated failing test is > > > > at TestSpanMultiTermQueryWrapper.TestFuzzy2() > > > > > > > > 7. An interesting failure to investigate is here: > > > > TestIndexableBinaryStringTools.TestEncodedSortability() -- probably a > > > > simple porting fail, a subtle Java <--> C# mismatch that we haven't > > > > noticed. > > > > > > > > Additionally, any help with porting the subprojects would be great. > > Some > > > > folks took some subprojects under their wings and never reported > back. > > If > > > > you could either complete the work, or donate whatever you have done > so > > > > far, that would be great. > > > > > > > > As always, get the code from here: > https://github.com/apache/lucenenet > > > -- > > > > work on your fork and send us a PR when ready, with a good > description > > of > > > > what you've done. > > > > > > > > To see the list of currently failing tests in real-time, go here (you > > can > > > > login as guest): > > > > > > > > > > > > > > http://teamcity.codebetter.com/viewType.html?buildTypeId=LuceneNet_Core&branch_LuceneNet=%3Cdefault%3E&tab=buildTypeStatusDiv > > > > > > > > Thanks, and happy searching, > > > > > > > > -- > > > > > > > > Itamar Syn-Hershko > > > > http://code972.com | @synhershko > > > > Freelance Developer & Consultant > > > > Lucene.NET committer and PMC member > > > > > > > > > > --001a113cdeac997b440513a19b95--