lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jeme <>
Subject [GitHub] lucenenet pull request #:
Date Fri, 15 Sep 2017 13:03:45 GMT
Github user jeme commented on the pull request:
    In that case I would probably advocate for adding a overloaded constructor:
    public ReplicationService(IDictionary<string, IReplicator> replicators, string context
= REPLICATION_CONTEXT) : this(new ReadOnlyDictionary(replicators), context) { }
    Or something... That would ease the use for those that wanted to use it in a completely
different context.
    I am not sure how much is it spread out or if it's actually all in the first commit, but
that is here:
    But Pulling that in directly is probably requires more effort that just going though the
code and finding the places where Readonly makes sense as the code as moved a bit since then.


View raw message