lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From synhershko <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Port of CharTokenizer, other code it depen...
Date Thu, 14 Jan 2016 09:41:06 GMT
Github user synhershko commented on a diff in the pull request:

    https://github.com/apache/lucenenet/pull/159#discussion_r49704493
  
    --- Diff: src/Lucene.Net.Analysis.Common/Analysis/Core/LetterTokenizer.cs ---
    @@ -75,10 +75,10 @@ public LetterTokenizer(LuceneVersion matchVersion, AttributeSource.AttributeFact
             /// <summary>
             /// Collects only characters which satisfy
             /// <seealso cref="Character#isLetter(int)"/>.
    -        /// </summary>	  
    -        protected override bool IsTokenChar(char c)
    +        /// </summary>
    +        protected override bool IsTokenChar(int c)
    --- End diff --
    
    IIRC I tried keeping it a char for .NET-ification reasons, but I can see how UTF32 can
force us back to int


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message