Return-Path: X-Original-To: apmail-lucenenet-dev-archive@www.apache.org Delivered-To: apmail-lucenenet-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B17BDCBE4 for ; Tue, 23 Dec 2014 17:28:44 +0000 (UTC) Received: (qmail 91098 invoked by uid 500); 23 Dec 2014 17:28:44 -0000 Delivered-To: apmail-lucenenet-dev-archive@lucenenet.apache.org Received: (qmail 91053 invoked by uid 500); 23 Dec 2014 17:28:44 -0000 Mailing-List: contact dev-help@lucenenet.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucenenet.apache.org Delivered-To: mailing list dev@lucenenet.apache.org Received: (qmail 91041 invoked by uid 99); 23 Dec 2014 17:28:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Dec 2014 17:28:43 +0000 X-ASF-Spam-Status: No, hits=2.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS,TVD_FROM_1 X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of itamar.synhershko@gmail.com designates 209.85.218.46 as permitted sender) Received: from [209.85.218.46] (HELO mail-oi0-f46.google.com) (209.85.218.46) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Dec 2014 17:28:39 +0000 Received: by mail-oi0-f46.google.com with SMTP id h136so14541173oig.5 for ; Tue, 23 Dec 2014 09:27:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=lsy8+20xn6sqszygJefnrAmiinTmbBNUfapq0h21Zts=; b=SdmSqzk8JoMdikvD/B003KF6b2/NHjjphqn3XueoubP1l5gKrwr0P9v9/EmZnFaXTX p4MXAnsPEvpGWf9QDvJn9kXHmJwMbgYat3jylynsgvzbe+qm7jOoKvgYEnDuh/htgSoH gxukGtjIedj0h3LQra8L6+IYxAcmFq1GVomSr0JvWjvUpUDSvD6Z5w2iNNP7wru3ow3u uNf5ictTGGGuhhWEpo7u61oRaIcMfLKWgoRn7DrNdtKvzysi2HXrWwHCN4v0jC0hL5AR hnzC4vUzfPVHKMrg+YbKZsRgJYOp8SixrlMsx49kDv3glktXWyHMyqpR6ZZcpyqwKFbM Icdg== MIME-Version: 1.0 X-Received: by 10.182.56.70 with SMTP id y6mr4082321obp.55.1419355654369; Tue, 23 Dec 2014 09:27:34 -0800 (PST) Sender: itamar.synhershko@gmail.com Received: by 10.182.197.98 with HTTP; Tue, 23 Dec 2014 09:27:34 -0800 (PST) In-Reply-To: References: Date: Tue, 23 Dec 2014 19:27:34 +0200 X-Google-Sender-Auth: Lm1YStL5pi27-KmbmKufJQu5Vg0 Message-ID: Subject: Re: Where should the tests be ported? From: Itamar Syn-Hershko To: "dev@lucenenet.apache.org" Content-Type: multipart/alternative; boundary=e89a8fb1ec5e96b8cc050ae57d41 X-Virus-Checked: Checked by ClamAV on apache.org --e89a8fb1ec5e96b8cc050ae57d41 Content-Type: text/plain; charset=UTF-8 It should be at /src/Lucene.Net.Tests.Classification - we'll revisit this pattern later to see it holds We'll probably need to refactor the Facets project's tests, I haven't noticed that actually -- Itamar Syn-Hershko http://code972.com | @synhershko Freelance Developer & Consultant Author of RavenDB in Action On Tue, Dec 23, 2014 at 7:21 PM, Laimonas Simutis wrote: > Recently I ported the classification project and will be doing its test > project next. > > My question is, which directory should the tests go to in Lucene.net? I am > looking at the "core" for a pattern, and see these two relevant > directories: > > /src/Lucene.Net.Core > /src/Lucene.Net.Tests/core > > Should the classification tests go to /src/Lucene.Net.Tests/classification > ? > > Looking for some guidance. > > Somewhat related, I see that Facet project has its test project in > /src/Lucene.Net.Tests/core even though java version ( > > https://github.com/apache/lucene-solr/tree/lucene_solr_4_8_0/lucene/core/src/test/org/apache/lucene > ) > has no facet directory or tests present. Perhaps it should be located here: > > /src/Lucene.Net.Tests/facet > > What do you guys think? I will start the port of classification tests, but > will wait on your guidance before sending in PR. > > > Laimonas > --e89a8fb1ec5e96b8cc050ae57d41--