Mailing-List: contact dev-help@lucenenet.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucenenet.apache.org
Received-SPF: pass (athena.apache.org: domain of Luc.Vanlerberghe@bvdinfo.com
 designates 193.194.158.169 as permitted sender)
From: "Vanlerberghe, Luc" <Luc.Vanlerberghe@bvdinfo.com>
To: "dev@lucenenet.apache.org" <dev@lucenenet.apache.org>
Subject: RE: [Possibly spoofed] GitHub pull requests vs. Jira issues
Thread-Topic: [Possibly spoofed] GitHub pull requests vs. Jira issues
Thread-Index: AdAYSvirHHkKdWrYQSCBNSxuSKEppgABPSdQ
Date: Mon, 15 Dec 2014 10:15:09 +0000
Message-ID: <0A67F2237DE0794AB6B734491041B1CC2530C379@mail-mbx-a.bvdep.net>
References: <0A67F2237DE0794AB6B734491041B1CC2530B328@mail-mbx-a.bvdep.net>
In-Reply-To: <0A67F2237DE0794AB6B734491041B1CC2530B328@mail-mbx-a.bvdep.net>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Oops, this was meant for lucene-dev, not lucenenet-dev

Sorry,

-----Original Message-----
From: Vanlerberghe, Luc [mailto:Luc.Vanlerberghe@bvdinfo.com]=20
Sent: maandag 15 december 2014 11:11
To: lucene-net-dev@lucene.apache.org
Subject: [Possibly spoofed] GitHub pull requests vs. Jira issues

Hi.

I recently created two pull requests via GitHub that arrived on the dev lis=
t automatically.
(They may have ended up in spam since I hadn't configured my name and email=
 yet, so the From: field was set to "LucVL <git@git.apache.org>")
I repeated the contents below just in case.

Do I need to set up corresponding JIRA issues to make sure they don't get l=
ost (or at least to know if they are rejected...) or are GitHub pull reques=
ts also reviewed regularly?

Thanks,

Luc


    https://github.com/apache/lucene-solr/pull/108

    o.a.l.queryparser.flexible.standard.StandardQueryParser cleanup

    * Removed unused, but confusing code (CONJ_AND =3D=3D CONJ_OR =3D=3D 2 =
???). Unfortunately, the code generated by JavaCC from the updated Standard=
SyntaxParser.jj differs in more places than necessary.
    * Replaced Vector by List/ArrayList.
    * Corrected the javadoc for StandardQueryParser.setLowercaseExpandedTer=
ms
   =20
    ant test in the queryparser directory runs successfully


    https://github.com/apache/lucene-solr/pull/113

    BitSet fixes

    * `LongBitSet.ensureCapacity` overflows on `numBits > Integer.MaxValue`
    * `Fixed-/LongBitSet`: Avoid conditional branch in `bits2words` (with a=
 comment explaining the formula)
   =20
    TODO:
    * Harmonize the use of `numWords` vs. `bits.length` vs. `numBits`
     * E.g.: `cardinality` scans up to `bits.length`, while `or` asserts on=
 `index<numBits`
    * If a `BitSet` is allocated with `n` bits, `ensureCapacity` with the s=
ame number `n` shouldn't grow the `BitSet`
     * Either both should allocate a larger array than really needed or nei=
ther.