lucenenet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nightowl...@apache.org
Subject [lucenenet] 23/29: Remove LuceneDocsPlugin dummy pack target and cleaned up a few comments
Date Tue, 09 Jul 2019 21:29:39 GMT
This is an automated email from the ASF dual-hosted git repository.

nightowl888 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucenenet.git

commit 201c216080973173907ac4ae408af85484c9502a
Author: Aaron Meyers <13340718+aaron-meyers@users.noreply.github.com>
AuthorDate: Mon Jul 8 12:06:46 2019 -0700

    Remove LuceneDocsPlugin dummy pack target and cleaned up a few comments
---
 src/Lucene.Net.TestFramework/Properties/AssemblyInfo.cs               | 2 +-
 src/Lucene.Net/Properties/AssemblyInfo.cs                             | 2 +-
 src/docs/LuceneDocsPlugins/LuceneDocsPlugins/LuceneDocsPlugins.csproj | 1 -
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/Lucene.Net.TestFramework/Properties/AssemblyInfo.cs b/src/Lucene.Net.TestFramework/Properties/AssemblyInfo.cs
index 5613ccf..178d7db 100644
--- a/src/Lucene.Net.TestFramework/Properties/AssemblyInfo.cs
+++ b/src/Lucene.Net.TestFramework/Properties/AssemblyInfo.cs
@@ -37,7 +37,7 @@ using System.Runtime.InteropServices;
 // The following GUID is for the ID of the typelib if this project is exposed to COM
 [assembly: Guid("5f36e3cf-82ac-4d97-af1a-6dabe60e9180")]
 
-// However, we need InternalsVisibleTo in order to prevent making everything public just
for the sake of testing.
+// We need InternalsVisibleTo in order to prevent making everything public just for the sake
of testing.
 // This has broad implications, though because many methods are marked "protected internal",
which means other assemblies
 // must update overridden methods to match.
 [assembly: InternalsVisibleTo("Lucene.Net.Tests, PublicKey=" + Lucene.Net.AssemblyKeys.PublicKey)]
diff --git a/src/Lucene.Net/Properties/AssemblyInfo.cs b/src/Lucene.Net/Properties/AssemblyInfo.cs
index 682242a..8ba038c 100644
--- a/src/Lucene.Net/Properties/AssemblyInfo.cs
+++ b/src/Lucene.Net/Properties/AssemblyInfo.cs
@@ -29,7 +29,7 @@ using System.Runtime.CompilerServices;
 
 [assembly: CLSCompliant(true)]
 
-// Besides strong naming, we still need InternalsVisibleTo in order to prevent making everything
public just for the sake of testing.
+// We need InternalsVisibleTo in order to prevent making everything public just for the sake
of testing.
 // This has broad implications because many methods are marked "protected internal", which
means other assemblies
 // must update overridden methods to match.
 [assembly: InternalsVisibleTo("Lucene.Net.Tests, PublicKey=" + Lucene.Net.AssemblyKeys.PublicKey)]
diff --git a/src/docs/LuceneDocsPlugins/LuceneDocsPlugins/LuceneDocsPlugins.csproj b/src/docs/LuceneDocsPlugins/LuceneDocsPlugins/LuceneDocsPlugins.csproj
index f51c451..2c771f8 100644
--- a/src/docs/LuceneDocsPlugins/LuceneDocsPlugins/LuceneDocsPlugins.csproj
+++ b/src/docs/LuceneDocsPlugins/LuceneDocsPlugins/LuceneDocsPlugins.csproj
@@ -104,5 +104,4 @@
     </PropertyGroup>
     <Error Condition="!Exists('..\packages\Microsoft.Net.Compilers.2.2.0\build\Microsoft.Net.Compilers.props')"
Text="$([System.String]::Format('$(ErrorText)', '..\packages\Microsoft.Net.Compilers.2.2.0\build\Microsoft.Net.Compilers.props'))"
/>
   </Target>
-  <Target Name="Pack" />
 </Project>


Mime
View raw message