lucenenet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nightowl...@apache.org
Subject [01/10] lucenenet git commit: Lucene.Net.Index.SegmentCoreReaders: Removed try catch block for AccessViolationException, which did not exist in Lucene. There does not appear to be a valid reason to include it.
Date Fri, 13 Oct 2017 11:09:58 GMT
Repository: lucenenet
Updated Branches:
  refs/heads/master b856f1eb0 -> d5ea2010a


Lucene.Net.Index.SegmentCoreReaders: Removed try catch block for AccessViolationException,
which did not exist in Lucene. There does not appear to be a valid reason to include it.


Project: http://git-wip-us.apache.org/repos/asf/lucenenet/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucenenet/commit/8081bbc1
Tree: http://git-wip-us.apache.org/repos/asf/lucenenet/tree/8081bbc1
Diff: http://git-wip-us.apache.org/repos/asf/lucenenet/diff/8081bbc1

Branch: refs/heads/master
Commit: 8081bbc1123b3fee183cd136d9faa91abb8854a6
Parents: b856f1e
Author: Shad Storhaug <shad@shadstorhaug.com>
Authored: Tue Oct 3 21:02:37 2017 +0700
Committer: Shad Storhaug <shad@shadstorhaug.com>
Committed: Tue Oct 3 21:02:37 2017 +0700

----------------------------------------------------------------------
 src/Lucene.Net/Index/SegmentCoreReaders.cs | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucenenet/blob/8081bbc1/src/Lucene.Net/Index/SegmentCoreReaders.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net/Index/SegmentCoreReaders.cs b/src/Lucene.Net/Index/SegmentCoreReaders.cs
index 6a406a2..d6fbee2 100644
--- a/src/Lucene.Net/Index/SegmentCoreReaders.cs
+++ b/src/Lucene.Net/Index/SegmentCoreReaders.cs
@@ -163,23 +163,7 @@ namespace Lucene.Net.Index
                     normsProducer = null;
                 }
 
-                // LUCENENET TODO: EXCEPTIONS Not sure why this catch block is swallowing
AccessViolationException, 
-                // because it didn't exist in Lucene. Is it really needed? AVE is for protected
memory...could
-                // this be needed because we are using unchecked??
-
-#if !NETSTANDARD
-                try
-                {
-#endif
-                    fieldsReaderOrig = si.Info.Codec.StoredFieldsFormat.FieldsReader(cfsDir,
si.Info, fieldInfos, context);
-#if !NETSTANDARD
-                }
-#pragma warning disable 168
-                catch (System.AccessViolationException ave)
-#pragma warning restore 168
-                {
-                }
-#endif
+                fieldsReaderOrig = si.Info.Codec.StoredFieldsFormat.FieldsReader(cfsDir,
si.Info, fieldInfos, context);
 
                 if (fieldInfos.HasVectors) // open term vector files only as needed
                 {


Mime
View raw message