lucenenet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nightowl...@apache.org
Subject [1/2] lucenenet git commit: Reviewed and removed unnecessary TODOs
Date Fri, 22 Sep 2017 13:11:14 GMT
Repository: lucenenet
Updated Branches:
  refs/heads/master 485403805 -> 40632593b


Reviewed and removed unnecessary TODOs


Project: http://git-wip-us.apache.org/repos/asf/lucenenet/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucenenet/commit/206f2e11
Tree: http://git-wip-us.apache.org/repos/asf/lucenenet/tree/206f2e11
Diff: http://git-wip-us.apache.org/repos/asf/lucenenet/diff/206f2e11

Branch: refs/heads/master
Commit: 206f2e11f5625d5e0589e6857c2a38cae6adcb51
Parents: 4854038
Author: Shad Storhaug <shad@shadstorhaug.com>
Authored: Fri Sep 22 19:53:04 2017 +0700
Committer: Shad Storhaug <shad@shadstorhaug.com>
Committed: Fri Sep 22 19:53:04 2017 +0700

----------------------------------------------------------------------
 .../Collation/CollationAttributeFactory.cs                        | 3 ---
 src/Lucene.Net.Analysis.Common/Collation/CollationKeyAnalyzer.cs  | 3 ---
 src/Lucene.Net.Analysis.Common/Collation/CollationKeyFilter.cs    | 3 ---
 .../Collation/TokenAttributes/CollatedTermAttributeImpl.cs        | 3 ---
 src/Lucene.Net.Codecs/Memory/DirectDocValuesConsumer.cs           | 2 +-
 src/Lucene.Net.Codecs/SimpleText/SimpleTextUtil.cs                | 2 +-
 src/Lucene.Net.Replicator/Http/ReplicationService.cs              | 1 -
 .../Analysis/Core/TestRandomChains.cs                             | 2 --
 .../Flexible/Precedence/TestPrecedenceQueryParser.cs              | 1 -
 src/dotnet/tools/Lucene.Net.Tests.Cli/Commands/CommandTestCase.cs | 1 -
 .../Lucene.Net.Tests.Cli/Commands/Index/IndexCheckCommandTest.cs  | 2 --
 11 files changed, 2 insertions(+), 21 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucenenet/blob/206f2e11/src/Lucene.Net.Analysis.Common/Collation/CollationAttributeFactory.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Analysis.Common/Collation/CollationAttributeFactory.cs b/src/Lucene.Net.Analysis.Common/Collation/CollationAttributeFactory.cs
index b1d289d..7129b20 100644
--- a/src/Lucene.Net.Analysis.Common/Collation/CollationAttributeFactory.cs
+++ b/src/Lucene.Net.Analysis.Common/Collation/CollationAttributeFactory.cs
@@ -67,9 +67,6 @@ namespace Lucene.Net.Collation
     ///   ICUCollationAttributeFactory on the query side, or vice versa.
     /// </para>
     /// </summary>
-    // LUCENENET TODO: A better option would be to contribute to the icu.net library and
-    // make it CLS compliant (at least the parts of it we use)
-    [System.CLSCompliant(false)]
     public class CollationAttributeFactory : AttributeSource.AttributeFactory
 	{
 		private readonly Collator collator;

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/206f2e11/src/Lucene.Net.Analysis.Common/Collation/CollationKeyAnalyzer.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Analysis.Common/Collation/CollationKeyAnalyzer.cs b/src/Lucene.Net.Analysis.Common/Collation/CollationKeyAnalyzer.cs
index 4028f0c..870a047 100644
--- a/src/Lucene.Net.Analysis.Common/Collation/CollationKeyAnalyzer.cs
+++ b/src/Lucene.Net.Analysis.Common/Collation/CollationKeyAnalyzer.cs
@@ -81,9 +81,6 @@ namespace Lucene.Net.Collation
     /// </list>
     /// </para>
     /// </summary>
-    // LUCENENET TODO: A better option would be to contribute to the icu.net library and
-    // make it CLS compliant (at least the parts of it we use)
-    [CLSCompliant(false)]
     public sealed class CollationKeyAnalyzer : Analyzer
 	{
 		private readonly Collator collator;

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/206f2e11/src/Lucene.Net.Analysis.Common/Collation/CollationKeyFilter.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Analysis.Common/Collation/CollationKeyFilter.cs b/src/Lucene.Net.Analysis.Common/Collation/CollationKeyFilter.cs
index d498f84..a91d549 100644
--- a/src/Lucene.Net.Analysis.Common/Collation/CollationKeyFilter.cs
+++ b/src/Lucene.Net.Analysis.Common/Collation/CollationKeyFilter.cs
@@ -71,9 +71,6 @@ namespace Lucene.Net.Collation
     /// @deprecated Use <see cref="CollationAttributeFactory"/> instead, which encodes
     ///  terms directly as bytes. This filter will be removed in Lucene 5.0 
     [Obsolete("Use CollationAttributeFactory instead, which encodes terms directly as bytes.
This filter will be removed in Lucene 5.0.")]
-    // LUCENENET TODO: A better option would be to contribute to the icu.net library and
-    // make it CLS compliant (at least the parts of it we use)
-    [CLSCompliant(false)]
     public sealed class CollationKeyFilter : TokenFilter
 	{
 		private readonly Collator collator;

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/206f2e11/src/Lucene.Net.Analysis.Common/Collation/TokenAttributes/CollatedTermAttributeImpl.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Analysis.Common/Collation/TokenAttributes/CollatedTermAttributeImpl.cs
b/src/Lucene.Net.Analysis.Common/Collation/TokenAttributes/CollatedTermAttributeImpl.cs
index bb8453d..68c614e 100644
--- a/src/Lucene.Net.Analysis.Common/Collation/TokenAttributes/CollatedTermAttributeImpl.cs
+++ b/src/Lucene.Net.Analysis.Common/Collation/TokenAttributes/CollatedTermAttributeImpl.cs
@@ -26,9 +26,6 @@ namespace Lucene.Net.Collation.TokenAttributes
     /// Extension of <see cref="CharTermAttribute"/> that encodes the term
     /// text as a binary Unicode collation key instead of as UTF-8 bytes.
     /// </summary>
-    // LUCENENET TODO: A better option would be to contribute to the icu.net library and
-    // make it CLS compliant (at least the parts of it we use)
-    [CLSCompliant(false)]
     public class CollatedTermAttributeImpl : CharTermAttribute
 	{
 		private readonly Collator collator;

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/206f2e11/src/Lucene.Net.Codecs/Memory/DirectDocValuesConsumer.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Codecs/Memory/DirectDocValuesConsumer.cs b/src/Lucene.Net.Codecs/Memory/DirectDocValuesConsumer.cs
index 4877481..e44986c 100644
--- a/src/Lucene.Net.Codecs/Memory/DirectDocValuesConsumer.cs
+++ b/src/Lucene.Net.Codecs/Memory/DirectDocValuesConsumer.cs
@@ -247,7 +247,7 @@ namespace Lucene.Net.Codecs.Memory
 
         // TODO: in some cases representing missing with minValue-1 wouldn't take up additional
space and so on,
         // but this is very simple, and algorithms only check this for values of 0 anyway
(doesnt slow down normal decode)
-        internal virtual void WriteMissingBitset<T1>(IEnumerable<T1> values)
// LUCENENET TODO: Rename generic parameter T ?
+        internal virtual void WriteMissingBitset<T1>(IEnumerable<T1> values)
         {
             long bits = 0;
             int count = 0;

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/206f2e11/src/Lucene.Net.Codecs/SimpleText/SimpleTextUtil.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Codecs/SimpleText/SimpleTextUtil.cs b/src/Lucene.Net.Codecs/SimpleText/SimpleTextUtil.cs
index c02df52..43ab450 100644
--- a/src/Lucene.Net.Codecs/SimpleText/SimpleTextUtil.cs
+++ b/src/Lucene.Net.Codecs/SimpleText/SimpleTextUtil.cs
@@ -30,7 +30,7 @@ namespace Lucene.Net.Codecs.SimpleText
 
     internal class SimpleTextUtil
     {
-        public static readonly byte NEWLINE = 10; // LUCENENET TODO: Should this be Environment.Newline?
+        public static readonly byte NEWLINE = 10;
         public static readonly byte ESCAPE = 92;
         internal static readonly BytesRef CHECKSUM = new BytesRef("checksum ");
 

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/206f2e11/src/Lucene.Net.Replicator/Http/ReplicationService.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Replicator/Http/ReplicationService.cs b/src/Lucene.Net.Replicator/Http/ReplicationService.cs
index 38692f9..b40d58d 100644
--- a/src/Lucene.Net.Replicator/Http/ReplicationService.cs
+++ b/src/Lucene.Net.Replicator/Http/ReplicationService.cs
@@ -190,7 +190,6 @@ namespace Lucene.Net.Replicator.Http
                 response.StatusCode = 500;
                 try
                 {
-                    // LUCENENET TODO: Add support for native serialization in .NET Framework/.NET
Standard 2.0 ?
                     TextWriter writer = new StreamWriter(response.Body);
                     JsonSerializer serializer = JsonSerializer.Create(JSON_SERIALIZER_SETTINGS);
                     serializer.Serialize(writer, e, e.GetType());

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/206f2e11/src/Lucene.Net.Tests.Analysis.Common/Analysis/Core/TestRandomChains.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Tests.Analysis.Common/Analysis/Core/TestRandomChains.cs b/src/Lucene.Net.Tests.Analysis.Common/Analysis/Core/TestRandomChains.cs
index fae5d75..d9f4a54 100644
--- a/src/Lucene.Net.Tests.Analysis.Common/Analysis/Core/TestRandomChains.cs
+++ b/src/Lucene.Net.Tests.Analysis.Common/Analysis/Core/TestRandomChains.cs
@@ -266,8 +266,6 @@ namespace Lucene.Net.Analysis.Core
 
             public virtual int Compare(ConstructorInfo arg0, ConstructorInfo arg1)
             {
-                // LUCENENET TODO: Need to ensure we have the right sort order
-                // original: arg0.toGenericString().compareTo(arg1.toGenericString());
                 return arg0.ToString().CompareToOrdinal(arg1.ToString());
             }
         }

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/206f2e11/src/Lucene.Net.Tests.QueryParser/Flexible/Precedence/TestPrecedenceQueryParser.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Tests.QueryParser/Flexible/Precedence/TestPrecedenceQueryParser.cs
b/src/Lucene.Net.Tests.QueryParser/Flexible/Precedence/TestPrecedenceQueryParser.cs
index d2a936e..2c4da33 100644
--- a/src/Lucene.Net.Tests.QueryParser/Flexible/Precedence/TestPrecedenceQueryParser.cs
+++ b/src/Lucene.Net.Tests.QueryParser/Flexible/Precedence/TestPrecedenceQueryParser.cs
@@ -482,7 +482,6 @@ namespace Lucene.Net.QueryParsers.Flexible.Precedence
             String hourField = "hour";
             PrecedenceQueryParser qp = new PrecedenceQueryParser(new MockAnalyzer(Random()));
 
-            // LUCENENET TODO: Can we eliminate this nullable??
             IDictionary<string, DateTools.Resolution?> fieldMap = new HashMap<string,
DateTools.Resolution?>();
             // set a field specific date resolution
             fieldMap.Put(monthField, DateTools.Resolution.MONTH);

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/206f2e11/src/dotnet/tools/Lucene.Net.Tests.Cli/Commands/CommandTestCase.cs
----------------------------------------------------------------------
diff --git a/src/dotnet/tools/Lucene.Net.Tests.Cli/Commands/CommandTestCase.cs b/src/dotnet/tools/Lucene.Net.Tests.Cli/Commands/CommandTestCase.cs
index 35485bf..92b1694 100644
--- a/src/dotnet/tools/Lucene.Net.Tests.Cli/Commands/CommandTestCase.cs
+++ b/src/dotnet/tools/Lucene.Net.Tests.Cli/Commands/CommandTestCase.cs
@@ -24,7 +24,6 @@ namespace Lucene.Net.Cli.Commands
      * limitations under the License.
      */
 
-    // LUCENENET TODO: Move to TestFramework ?
     public abstract class CommandTestCase : LuceneTestCase
     {
         protected abstract ConfigurationBase CreateConfiguration(MockConsoleApp app);

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/206f2e11/src/dotnet/tools/Lucene.Net.Tests.Cli/Commands/Index/IndexCheckCommandTest.cs
----------------------------------------------------------------------
diff --git a/src/dotnet/tools/Lucene.Net.Tests.Cli/Commands/Index/IndexCheckCommandTest.cs
b/src/dotnet/tools/Lucene.Net.Tests.Cli/Commands/Index/IndexCheckCommandTest.cs
index 8193ca5..33d9d41 100644
--- a/src/dotnet/tools/Lucene.Net.Tests.Cli/Commands/Index/IndexCheckCommandTest.cs
+++ b/src/dotnet/tools/Lucene.Net.Tests.Cli/Commands/Index/IndexCheckCommandTest.cs
@@ -21,8 +21,6 @@ namespace Lucene.Net.Cli.Commands
      * limitations under the License.
      */
 
-    // LUCENENET TODO: Test to ensure all of the commands and arguments have a description
(in all commands except for root)
-
     public class IndexCheckCommandTest : CommandTestCase
     {
         protected override ConfigurationBase CreateConfiguration(MockConsoleApp app)


Mime
View raw message