lucenenet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nightowl...@apache.org
Subject [04/20] lucenenet git commit: Reviewed and removed some TODOs
Date Sun, 02 Apr 2017 07:06:04 GMT
Reviewed and removed some TODOs


Project: http://git-wip-us.apache.org/repos/asf/lucenenet/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucenenet/commit/a8502e36
Tree: http://git-wip-us.apache.org/repos/asf/lucenenet/tree/a8502e36
Diff: http://git-wip-us.apache.org/repos/asf/lucenenet/diff/a8502e36

Branch: refs/heads/api-work
Commit: a8502e36f852ef67ca943fc17866dd4f3fd9dbfc
Parents: 4e54801
Author: Shad Storhaug <shad@shadstorhaug.com>
Authored: Sun Apr 2 09:23:54 2017 +0700
Committer: Shad Storhaug <shad@shadstorhaug.com>
Committed: Sun Apr 2 09:23:54 2017 +0700

----------------------------------------------------------------------
 .../Codecs/Lucene42/Lucene42DocValuesProducer.cs  |  2 +-
 .../Search/ControlledRealTimeReopenThread.cs      |  2 +-
 .../Analysis/MockTokenizer.cs                     | 18 +++++++++---------
 .../Codecs/Lucene40/Lucene40DocValuesWriter.cs    |  2 +-
 4 files changed, 12 insertions(+), 12 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucenenet/blob/a8502e36/src/Lucene.Net.Core/Codecs/Lucene42/Lucene42DocValuesProducer.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Core/Codecs/Lucene42/Lucene42DocValuesProducer.cs b/src/Lucene.Net.Core/Codecs/Lucene42/Lucene42DocValuesProducer.cs
index 010adb0..4503588 100644
--- a/src/Lucene.Net.Core/Codecs/Lucene42/Lucene42DocValuesProducer.cs
+++ b/src/Lucene.Net.Core/Codecs/Lucene42/Lucene42DocValuesProducer.cs
@@ -290,7 +290,7 @@ namespace Lucene.Net.Codecs.Lucene42
                     return new NumericDocValuesAnonymousInnerClassHelper3(min, mult, quotientReader);
 
                 default:
-                    throw new InvalidOperationException(); // LUCENENET TODO: This was AssertionError
in Lucene - does this need a fix?
+                    throw new InvalidOperationException();
             }
         }
 

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/a8502e36/src/Lucene.Net.Core/Search/ControlledRealTimeReopenThread.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Core/Search/ControlledRealTimeReopenThread.cs b/src/Lucene.Net.Core/Search/ControlledRealTimeReopenThread.cs
index ccdffa9..34f4f9a 100644
--- a/src/Lucene.Net.Core/Search/ControlledRealTimeReopenThread.cs
+++ b/src/Lucene.Net.Core/Search/ControlledRealTimeReopenThread.cs
@@ -117,7 +117,7 @@ namespace Lucene.Net.Search
             reopenCond.Reset();
         }
 
-        public void Dispose() // LUCENENET TODO: Implement disposable pattern
+        public void Dispose()
         {
             finish = true;
             reopenCond.Set();

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/a8502e36/src/Lucene.Net.TestFramework/Analysis/MockTokenizer.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.TestFramework/Analysis/MockTokenizer.cs b/src/Lucene.Net.TestFramework/Analysis/MockTokenizer.cs
index e557eee..2889557 100644
--- a/src/Lucene.Net.TestFramework/Analysis/MockTokenizer.cs
+++ b/src/Lucene.Net.TestFramework/Analysis/MockTokenizer.cs
@@ -257,15 +257,15 @@ namespace Lucene.Net.Analysis
                         int ret = m_input.Read(c, 1, 1);
                         return ret <= 0 ? -1 : c[1];
                     }
-                /* LUCENE TO-DO not sure if needed, CharBuffer not supported
-                  case 2:
-                  {
-                    // read(CharBuffer)
-                    char[] c = new char[1];
-                    CharBuffer cb = CharBuffer.Wrap(c);
-                    int ret = Input.Read(cb);
-                    return ret < 0 ? ret : c[0];
-                  }*/
+                // LUCENENET NOTE: CharBuffer not supported
+                //case 2:
+                //    {
+                //        // read(CharBuffer)
+                //        char[] c = new char[1];
+                //        CharBuffer cb = CharBuffer.Wrap(c);
+                //        int ret = m_input.Read(cb);
+                //        return ret < 0 ? ret : c[0];
+                //    }
                 default:
                     // read()
                     return m_input.Read();

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/a8502e36/src/Lucene.Net.TestFramework/Codecs/Lucene40/Lucene40DocValuesWriter.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.TestFramework/Codecs/Lucene40/Lucene40DocValuesWriter.cs b/src/Lucene.Net.TestFramework/Codecs/Lucene40/Lucene40DocValuesWriter.cs
index 51c4b36..18b157f 100644
--- a/src/Lucene.Net.TestFramework/Codecs/Lucene40/Lucene40DocValuesWriter.cs
+++ b/src/Lucene.Net.TestFramework/Codecs/Lucene40/Lucene40DocValuesWriter.cs
@@ -73,7 +73,7 @@ namespace Lucene.Net.Codecs.Lucene40
                     // fits in a byte[], would be more than 4bpv, just write byte[]
                     AddBytesField(field, data, values);
                 }
-                else if (minValue >= short.MinValue && maxValue <= short.MaxValue
&& PackedInt32s.BitsRequired(maxValue - minValue) > 8) // LUCENENET TODO: Shouldn't
this be ushort.MinValue & MaxValue?
+                else if (minValue >= short.MinValue && maxValue <= short.MaxValue
&& PackedInt32s.BitsRequired(maxValue - minValue) > 8)
                 {
                     // fits in a short[], would be more than 8bpv, just write short[]
                     AddShortsField(field, data, values);


Mime
View raw message