lucenenet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nightowl...@apache.org
Subject [2/3] lucenenet git commit: Lucene.Net.Util.Constants: Removed .NET Reflection code that reads the version at runtime. Will replace the version before build using the build script instead, which will be more reliable across runtimes and faster overall.
Date Tue, 11 Apr 2017 18:16:29 GMT
Lucene.Net.Util.Constants: Removed .NET Reflection code that reads the version at runtime.
Will replace the version before build using the build script instead, which will be more reliable
across runtimes and faster overall.


Project: http://git-wip-us.apache.org/repos/asf/lucenenet/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucenenet/commit/2dd2fa44
Tree: http://git-wip-us.apache.org/repos/asf/lucenenet/tree/2dd2fa44
Diff: http://git-wip-us.apache.org/repos/asf/lucenenet/diff/2dd2fa44

Branch: refs/heads/api-work
Commit: 2dd2fa447b9b1f2eefc78f17ebd52d57e5b89c98
Parents: 25f0329
Author: Shad Storhaug <shad@shadstorhaug.com>
Authored: Wed Apr 12 00:07:35 2017 +0700
Committer: Shad Storhaug <shad@shadstorhaug.com>
Committed: Wed Apr 12 00:07:35 2017 +0700

----------------------------------------------------------------------
 src/Lucene.Net/Util/Constants.cs | 38 +++++------------------------------
 1 file changed, 5 insertions(+), 33 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucenenet/blob/2dd2fa44/src/Lucene.Net/Util/Constants.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net/Util/Constants.cs b/src/Lucene.Net/Util/Constants.cs
index 4be1dcf..1086467 100644
--- a/src/Lucene.Net/Util/Constants.cs
+++ b/src/Lucene.Net/Util/Constants.cs
@@ -111,38 +111,6 @@ namespace Lucene.Net.Util
                 RUNTIME_IS_64BIT = false;// 32 bit machine
             }
 
-            try
-            {
-                // LUCENENET NOTE: Use the AssemblyFileVersion, since our AssemblyVersion
should 
-                // remain at the major version (4.0.0.0). We only increment AssemblyVersion

-                // during a major release because strong-naming means 
-                // incrementing this version makes it binary incompatible.
-                string versionString;
-#if NETSTANDARD
-                versionString = typeof(Constants).GetTypeInfo().Assembly.GetCustomAttribute<AssemblyFileVersionAttribute>().Version;
-#else
-                versionString = FileVersionInfo.GetVersionInfo(typeof(Constants).GetTypeInfo().Assembly.Location).FileVersion;
-#endif
-                // LUCENENET NOTE: Convert to a 4-segment version number (in case it isn't)
-                switch (versionString.Count(x => x == '.'))
-                {
-                    case 2:
-                        versionString += ".0";
-                        break;
-                    case 1:
-                        versionString += ".0.0";
-                        break;
-                    case 0:
-                        versionString += ".0.0.0";
-                        break;
-                }
-
-                LUCENE_VERSION = versionString;
-            }
-            catch (System.Security.SecurityException) //Ignore in medium trust.
-            {
-            }
-
             //LUCENENET NOTE: Well that was all over the top to check architechture
             //bool is64Bit = false;
             //try
@@ -213,10 +181,14 @@ namespace Lucene.Net.Util
         /// </summary>
         public static readonly string LUCENE_MAIN_VERSION = Ident("4.8");
 
+        // LUCENENET NOTE: This version is automatically updated by the
+        // build script, so there is no need to change it here (although
+        // it might make sense to change it when a major/minor/patch
+        // port to Lucene is done).
         /// <summary>
         /// this is the Lucene version for display purposes.
         /// </summary>
-        public static readonly string LUCENE_VERSION;
+        public static readonly string LUCENE_VERSION = "4.8.0";
 
         /// <summary>
         /// Returns a LUCENE_MAIN_VERSION without any ALPHA/BETA qualifier


Mime
View raw message