lucenenet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nightowl...@apache.org
Subject [06/23] lucenenet git commit: Added various TODOs for API changes
Date Sun, 19 Mar 2017 23:20:01 GMT
Added various TODOs for API changes


Project: http://git-wip-us.apache.org/repos/asf/lucenenet/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucenenet/commit/a5db3879
Tree: http://git-wip-us.apache.org/repos/asf/lucenenet/tree/a5db3879
Diff: http://git-wip-us.apache.org/repos/asf/lucenenet/diff/a5db3879

Branch: refs/heads/api-work
Commit: a5db3879e04359f6ea5089fd90d9f8e790f2f180
Parents: 6d3da67
Author: Shad Storhaug <shad@shadstorhaug.com>
Authored: Sun Mar 19 21:09:35 2017 +0700
Committer: Shad Storhaug <shad@shadstorhaug.com>
Committed: Sun Mar 19 22:41:07 2017 +0700

----------------------------------------------------------------------
 src/Lucene.Net.Codecs/Sep/IntIndexInput.cs    | 4 ++--
 src/Lucene.Net.Codecs/Sep/IntIndexOutput.cs   | 2 +-
 src/Lucene.Net.Core/Index/NumericDocValues.cs | 2 +-
 src/Lucene.Net.Core/Store/IndexOutput.cs      | 2 +-
 src/Lucene.Net.Core/Store/RAMFile.cs          | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucenenet/blob/a5db3879/src/Lucene.Net.Codecs/Sep/IntIndexInput.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Codecs/Sep/IntIndexInput.cs b/src/Lucene.Net.Codecs/Sep/IntIndexInput.cs
index efb853e..b56661f 100644
--- a/src/Lucene.Net.Codecs/Sep/IntIndexInput.cs
+++ b/src/Lucene.Net.Codecs/Sep/IntIndexInput.cs
@@ -37,7 +37,7 @@ namespace Lucene.Net.Codecs.Sep
 
         /// <summary>
         /// Records a single skip-point in the <see cref="Int32IndexInput.GetReader"/>.
</summary>
-        public abstract class AbstractIndex
+        public abstract class AbstractIndex // LUCENENET TODO: API Change back to Index ?
Or make interface so names don't collide?
         {
             public abstract void Read(DataInput indexIn, bool absolute);
 
@@ -50,7 +50,7 @@ namespace Lucene.Net.Codecs.Sep
         }
 
         /// <summary>Reads int values</summary>
-        public abstract class AbstractReader
+        public abstract class AbstractReader // LUCENENET TODO: Change back to Reader ? Or
make interface so names don't collide?
         {
             /// <summary>Reads next single int</summary>
             public abstract int Next();

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/a5db3879/src/Lucene.Net.Codecs/Sep/IntIndexOutput.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Codecs/Sep/IntIndexOutput.cs b/src/Lucene.Net.Codecs/Sep/IntIndexOutput.cs
index 65eecec..54b9070 100644
--- a/src/Lucene.Net.Codecs/Sep/IntIndexOutput.cs
+++ b/src/Lucene.Net.Codecs/Sep/IntIndexOutput.cs
@@ -43,7 +43,7 @@ namespace Lucene.Net.Codecs.Sep
         public abstract void Write(int v);
 
         /// <summary>Records a single skip-point in the IndexOutput. </summary>
-        public abstract class AbstractIndex
+        public abstract class AbstractIndex // LUCENENET TODO: API Change back to Index ?
Or make interface so names don't collide?
         {
             /// <summary>Internally records the current location </summary>
             public abstract void Mark();

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/a5db3879/src/Lucene.Net.Core/Index/NumericDocValues.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Core/Index/NumericDocValues.cs b/src/Lucene.Net.Core/Index/NumericDocValues.cs
index ba13d6e..46da6b4 100644
--- a/src/Lucene.Net.Core/Index/NumericDocValues.cs
+++ b/src/Lucene.Net.Core/Index/NumericDocValues.cs
@@ -34,6 +34,6 @@ namespace Lucene.Net.Index
         /// Returns the numeric value for the specified document ID. </summary>
         /// <param name="docID"> document ID to lookup </param>
         /// <returns> numeric value </returns>
-        public abstract long Get(int docID);
+        public abstract long Get(int docID); // LUCENENET TODO: API Change to this[docID]
(and check API for consistency)
     }
 }
\ No newline at end of file

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/a5db3879/src/Lucene.Net.Core/Store/IndexOutput.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Core/Store/IndexOutput.cs b/src/Lucene.Net.Core/Store/IndexOutput.cs
index 6034f9d..8342316 100644
--- a/src/Lucene.Net.Core/Store/IndexOutput.cs
+++ b/src/Lucene.Net.Core/Store/IndexOutput.cs
@@ -42,7 +42,7 @@ namespace Lucene.Net.Store
         /// Returns the current position in this file, where the next write will
         /// occur. </summary>
         /// <seealso cref= #seek(long) </seealso>
-        public abstract long FilePointer { get; }
+        public abstract long FilePointer { get; } // LUCENENET TODO: API Change to GetFilePointer()
(makes conversion)
 
         /// <summary>
         /// Sets current position in this file, where the next write will occur. </summary>

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/a5db3879/src/Lucene.Net.Core/Store/RAMFile.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Core/Store/RAMFile.cs b/src/Lucene.Net.Core/Store/RAMFile.cs
index cc8e87e..eff95b0 100644
--- a/src/Lucene.Net.Core/Store/RAMFile.cs
+++ b/src/Lucene.Net.Core/Store/RAMFile.cs
@@ -75,7 +75,7 @@ namespace Lucene.Net.Store
             return buffer;
         }
 
-        protected internal byte[] GetBuffer(int index)
+        protected internal byte[] GetBuffer(int index) // LUCENENET TODO: API Make Buffer[]
property
         {
             lock (this)
             {


Mime
View raw message