lucenenet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nightowl...@apache.org
Subject [16/23] lucenenet git commit: Reviewed and removed some TODOs
Date Sun, 19 Mar 2017 23:20:11 GMT
Reviewed and removed some TODOs


Project: http://git-wip-us.apache.org/repos/asf/lucenenet/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucenenet/commit/b6b76c70
Tree: http://git-wip-us.apache.org/repos/asf/lucenenet/tree/b6b76c70
Diff: http://git-wip-us.apache.org/repos/asf/lucenenet/diff/b6b76c70

Branch: refs/heads/api-work
Commit: b6b76c70965e90596ee90e5fe9c971e0a47fdeb3
Parents: d2825f7
Author: Shad Storhaug <shad@shadstorhaug.com>
Authored: Sun Mar 19 23:25:26 2017 +0700
Committer: Shad Storhaug <shad@shadstorhaug.com>
Committed: Sun Mar 19 23:25:26 2017 +0700

----------------------------------------------------------------------
 src/Lucene.Net.Core/Index/NumericDocValues.cs                      | 2 +-
 .../Analysis/Core/TestTypeTokenFilterFactory.cs                    | 2 +-
 .../Analysis/NGram/EdgeNGramTokenizerTest.cs                       | 1 -
 3 files changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucenenet/blob/b6b76c70/src/Lucene.Net.Core/Index/NumericDocValues.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Core/Index/NumericDocValues.cs b/src/Lucene.Net.Core/Index/NumericDocValues.cs
index 46da6b4..ba13d6e 100644
--- a/src/Lucene.Net.Core/Index/NumericDocValues.cs
+++ b/src/Lucene.Net.Core/Index/NumericDocValues.cs
@@ -34,6 +34,6 @@ namespace Lucene.Net.Index
         /// Returns the numeric value for the specified document ID. </summary>
         /// <param name="docID"> document ID to lookup </param>
         /// <returns> numeric value </returns>
-        public abstract long Get(int docID); // LUCENENET TODO: API Change to this[docID]
(and check API for consistency)
+        public abstract long Get(int docID);
     }
 }
\ No newline at end of file

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/b6b76c70/src/Lucene.Net.Tests.Analysis.Common/Analysis/Core/TestTypeTokenFilterFactory.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Tests.Analysis.Common/Analysis/Core/TestTypeTokenFilterFactory.cs
b/src/Lucene.Net.Tests.Analysis.Common/Analysis/Core/TestTypeTokenFilterFactory.cs
index abb83e7..bd0dbde 100644
--- a/src/Lucene.Net.Tests.Analysis.Common/Analysis/Core/TestTypeTokenFilterFactory.cs
+++ b/src/Lucene.Net.Tests.Analysis.Common/Analysis/Core/TestTypeTokenFilterFactory.cs
@@ -48,7 +48,7 @@ namespace Lucene.Net.Analysis.Core
         {
             TokenFilterFactory factory = TokenFilterFactory("Type", "types", "stoptypes-1.txt,
stoptypes-2.txt", "enablePositionIncrements", "true");
             NumericTokenStream input = new NumericTokenStream();
-            input.SetInt32Value(123); // LUCENENET TODO: Shouldn't this be a property setter?
+            input.SetInt32Value(123);
             factory.Create(input);
         }
 

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/b6b76c70/src/Lucene.Net.Tests.Analysis.Common/Analysis/NGram/EdgeNGramTokenizerTest.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Tests.Analysis.Common/Analysis/NGram/EdgeNGramTokenizerTest.cs
b/src/Lucene.Net.Tests.Analysis.Common/Analysis/NGram/EdgeNGramTokenizerTest.cs
index 4ccecfa..6cddafe 100644
--- a/src/Lucene.Net.Tests.Analysis.Common/Analysis/NGram/EdgeNGramTokenizerTest.cs
+++ b/src/Lucene.Net.Tests.Analysis.Common/Analysis/NGram/EdgeNGramTokenizerTest.cs
@@ -203,7 +203,6 @@ namespace Lucene.Net.Analysis.NGram
 
         private static void TestNGrams(int minGram, int maxGram, int length, string nonTokenChars)
         {
-            // LUCENENET TODO: Changed randomizing strategy - not sure if this is right...
             //string s = RandomStrings.randomAsciiOfLength(Random(), length);
             string s = TestUtil.RandomAnalysisString(Random(), length, true);
             TestNGrams(minGram, maxGram, s, nonTokenChars);


Mime
View raw message