lucenenet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nightowl...@apache.org
Subject [02/16] lucenenet git commit: Added TODO about changing the background merge exception to include all exceptions that were encountered in the resultant exception.
Date Sat, 11 Mar 2017 05:52:55 GMT
Added TODO about changing the background merge exception to include all exceptions that were
encountered in the resultant exception.


Project: http://git-wip-us.apache.org/repos/asf/lucenenet/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucenenet/commit/33b5db47
Tree: http://git-wip-us.apache.org/repos/asf/lucenenet/tree/33b5db47
Diff: http://git-wip-us.apache.org/repos/asf/lucenenet/diff/33b5db47

Branch: refs/heads/api-work
Commit: 33b5db475d3f1371c072f64227f41f7ce431fec8
Parents: c96a083
Author: Shad Storhaug <shad@shadstorhaug.com>
Authored: Thu Mar 9 20:25:53 2017 +0700
Committer: Shad Storhaug <shad@shadstorhaug.com>
Committed: Thu Mar 9 20:25:53 2017 +0700

----------------------------------------------------------------------
 src/Lucene.Net.Core/Index/IndexWriter.cs | 5 +++++
 1 file changed, 5 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucenenet/blob/33b5db47/src/Lucene.Net.Core/Index/IndexWriter.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Core/Index/IndexWriter.cs b/src/Lucene.Net.Core/Index/IndexWriter.cs
index f198c98..c0fbb3d 100644
--- a/src/Lucene.Net.Core/Index/IndexWriter.cs
+++ b/src/Lucene.Net.Core/Index/IndexWriter.cs
@@ -2163,6 +2163,11 @@ namespace Lucene.Net.Index
                             int size = mergeExceptions.Count;
                             for (int i = 0; i < size; i++)
                             {
+                                // LUCENENET TODO: Perhaps it would make more sense to throw
an Exception (IOException??)
+                                // that has an AggregateException passed as its innerException
argument.
+                                // But, need to investigate what type of exceptions this
should throw and make sure 
+                                // the exception thrown here is caught in the right places,
if necessary.
+
                                 MergePolicy.OneMerge merge = mergeExceptions[i];
                                 if (merge.MaxNumSegments != -1)
                                 {


Mime
View raw message