lucenenet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nightowl...@apache.org
Subject [37/47] lucenenet git commit: Reverted test method stubs on Misc.Index.Sorter.SorterTestBase-derived test classes so this state can be returned to later when swapping test frameworks to xUnit.
Date Tue, 11 Oct 2016 18:35:22 GMT
Reverted test method stubs on Misc.Index.Sorter.SorterTestBase-derived test classes so this
state can be returned to later when swapping test frameworks to xUnit.


Project: http://git-wip-us.apache.org/repos/asf/lucenenet/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucenenet/commit/b4bbbeff
Tree: http://git-wip-us.apache.org/repos/asf/lucenenet/tree/b4bbbeff
Diff: http://git-wip-us.apache.org/repos/asf/lucenenet/diff/b4bbbeff

Branch: refs/heads/master
Commit: b4bbbeffe61f04a83c89ea3ba8b242b42efa7767
Parents: 70ae196
Author: Shad Storhaug <shad@shadstorhaug.com>
Authored: Tue Oct 11 03:31:46 2016 +0700
Committer: Shad Storhaug <shad@shadstorhaug.com>
Committed: Wed Oct 12 01:10:56 2016 +0700

----------------------------------------------------------------------
 .../Index/Sorter/IndexSortingTest.cs            | 55 --------------------
 .../Index/Sorter/SorterTestBase.cs              |  8 +++
 .../Index/Sorter/SortingAtomicReaderTest.cs     | 55 --------------------
 3 files changed, 8 insertions(+), 110 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucenenet/blob/b4bbbeff/src/Lucene.Net.Tests.Misc/Index/Sorter/IndexSortingTest.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Tests.Misc/Index/Sorter/IndexSortingTest.cs b/src/Lucene.Net.Tests.Misc/Index/Sorter/IndexSortingTest.cs
index fcd1e1e..164f275 100644
--- a/src/Lucene.Net.Tests.Misc/Index/Sorter/IndexSortingTest.cs
+++ b/src/Lucene.Net.Tests.Misc/Index/Sorter/IndexSortingTest.cs
@@ -87,60 +87,5 @@ namespace Lucene.Net.Index.Sorter
             reader = SlowCompositeReaderWrapper.Wrap(DirectoryReader.Open(dir));
             assertFalse("index should not have deletions", reader.HasDeletions);
         }
-
-
-        // LUCENENET NOTE: According to this answer, you are supposed to be able to
-        // put tests in an abstract class to run them from multiple places with different
-        // test input. However, that doesn't seem to work in Visual Studio - it doesn't
-        // find any test in an abstract class. So, this is a (not so great) workaround
-        // to run the tests from multiple places without having to duplicate the test code.
-
-        [Test]
-        public override void TestBinaryDocValuesField()
-        {
-            base.TestBinaryDocValuesField();
-        }
-
-        [Test]
-        public override void TestDocsAndPositionsEnum()
-        {
-            base.TestDocsAndPositionsEnum();
-        }
-
-        [Test]
-        public override void TestDocsEnum()
-        {
-            base.TestDocsEnum();
-        }
-
-        [Test]
-        public override void TestNormValues()
-        {
-            base.TestNormValues();
-        }
-
-        [Test]
-        public override void TestNumericDocValuesField()
-        {
-            base.TestNumericDocValuesField();
-        }
-
-        [Test]
-        public override void TestSortedDocValuesField()
-        {
-            base.TestSortedDocValuesField();
-        }
-
-        [Test]
-        public override void TestSortedSetDocValuesField()
-        {
-            base.TestSortedSetDocValuesField();
-        }
-
-        [Test]
-        public override void TestTermVectors()
-        {
-            base.TestTermVectors();
-        }
     }
 }

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/b4bbbeff/src/Lucene.Net.Tests.Misc/Index/Sorter/SorterTestBase.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Tests.Misc/Index/Sorter/SorterTestBase.cs b/src/Lucene.Net.Tests.Misc/Index/Sorter/SorterTestBase.cs
index ba760e6..2cff135 100644
--- a/src/Lucene.Net.Tests.Misc/Index/Sorter/SorterTestBase.cs
+++ b/src/Lucene.Net.Tests.Misc/Index/Sorter/SorterTestBase.cs
@@ -230,6 +230,7 @@ namespace Lucene.Net.Index.Sorter
             dir.Dispose();
         }
 
+        [Test]
         public virtual void TestBinaryDocValuesField()
         {
             BinaryDocValues dv = reader.GetBinaryDocValues(BINARY_DV_FIELD);
@@ -241,6 +242,7 @@ namespace Lucene.Net.Index.Sorter
             }
         }
 
+        [Test]
         public virtual void TestDocsAndPositionsEnum()
         {
             TermsEnum termsEnum = reader.Terms(DOC_POSITIONS_FIELD).Iterator(null);
@@ -320,6 +322,7 @@ namespace Lucene.Net.Index.Sorter
             return bits;
         }
 
+        [Test]
         public virtual void TestDocsEnum()
         {
             Bits mappedLiveDocs = RandomLiveDocs(reader.MaxDoc);
@@ -366,6 +369,7 @@ namespace Lucene.Net.Index.Sorter
             }
         }
 
+        [Test]
         public virtual void TestNormValues()
         {
             NumericDocValues dv = reader.GetNormValues(NORMS_FIELD);
@@ -376,6 +380,7 @@ namespace Lucene.Net.Index.Sorter
             }
         }
 
+        [Test]
         public virtual void TestNumericDocValuesField()
         {
             NumericDocValues dv = reader.GetNumericDocValues(NUMERIC_DV_FIELD);
@@ -386,6 +391,7 @@ namespace Lucene.Net.Index.Sorter
             }
         }
 
+        [Test]
         public virtual void TestSortedDocValuesField()
         {
             SortedDocValues dv = reader.GetSortedDocValues(SORTED_DV_FIELD);
@@ -398,6 +404,7 @@ namespace Lucene.Net.Index.Sorter
             }
         }
 
+        [Test]
         public virtual void TestSortedSetDocValuesField()
         {
             AssumeTrue("default codec does not support SORTED_SET", DefaultCodecSupportsSortedSet());
@@ -416,6 +423,7 @@ namespace Lucene.Net.Index.Sorter
             }
         }
 
+        [Test]
         public virtual void TestTermVectors()
         {
             int maxDoc = reader.MaxDoc;

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/b4bbbeff/src/Lucene.Net.Tests.Misc/Index/Sorter/SortingAtomicReaderTest.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Tests.Misc/Index/Sorter/SortingAtomicReaderTest.cs b/src/Lucene.Net.Tests.Misc/Index/Sorter/SortingAtomicReaderTest.cs
index ec95d73..cb2b38e 100644
--- a/src/Lucene.Net.Tests.Misc/Index/Sorter/SortingAtomicReaderTest.cs
+++ b/src/Lucene.Net.Tests.Misc/Index/Sorter/SortingAtomicReaderTest.cs
@@ -79,60 +79,5 @@ namespace Lucene.Net.Index.Sorter
                 assertEquals("Cannot sort an index with a Sort that refers to the relevance
score", e.Message);
             }
         }
-
-
-        // LUCENENET NOTE: According to this answer, you are supposed to be able to
-        // put tests in an abstract class to run them from multiple places with different
-        // test input. However, that doesn't seem to work in Visual Studio - it doesn't
-        // find any test in an abstract class. So, this is a (not so great) workaround
-        // to run the tests from multiple places without having to duplicate the test code.
-
-        [Test]
-        public override void TestBinaryDocValuesField()
-        {
-            base.TestBinaryDocValuesField();
-        }
-
-        [Test]
-        public override void TestDocsAndPositionsEnum()
-        {
-            base.TestDocsAndPositionsEnum();
-        }
-
-        [Test]
-        public override void TestDocsEnum()
-        {
-            base.TestDocsEnum();
-        }
-
-        [Test]
-        public override void TestNormValues()
-        {
-            base.TestNormValues();
-        }
-
-        [Test]
-        public override void TestNumericDocValuesField()
-        {
-            base.TestNumericDocValuesField();
-        }
-
-        [Test]
-        public override void TestSortedDocValuesField()
-        {
-            base.TestSortedDocValuesField();
-        }
-
-        [Test]
-        public override void TestSortedSetDocValuesField()
-        {
-            base.TestSortedSetDocValuesField();
-        }
-
-        [Test]
-        public override void TestTermVectors()
-        {
-            base.TestTermVectors();
-        }
     }
 }


Mime
View raw message