Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id ADEF0200B74 for ; Thu, 1 Sep 2016 16:36:32 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id ACCB1160AA8; Thu, 1 Sep 2016 14:36:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E4820160ACF for ; Thu, 1 Sep 2016 16:36:31 +0200 (CEST) Received: (qmail 57787 invoked by uid 500); 1 Sep 2016 14:36:22 -0000 Mailing-List: contact commits-help@lucenenet.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: lucene-net-dev@lucenenet.apache.org Delivered-To: mailing list commits@lucenenet.apache.org Received: (qmail 57432 invoked by uid 99); 1 Sep 2016 14:36:22 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Sep 2016 14:36:22 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 5728CE0B66; Thu, 1 Sep 2016 14:36:22 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: synhershko@apache.org To: commits@lucenenet.apache.org Date: Thu, 01 Sep 2016 14:36:32 -0000 Message-Id: In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [12/22] lucenenet git commit: Fixed bug in HTMLStripCharFilter that was not allowing null characters to pass from the reader to the business logic, which was causing the Analysis.CharFilters.HTMLStripCharFilterTest.TestRandom() and Analysis.CharFilters.H archived-at: Thu, 01 Sep 2016 14:36:32 -0000 Fixed bug in HTMLStripCharFilter that was not allowing null characters to pass from the reader to the business logic, which was causing the Analysis.CharFilters.HTMLStripCharFilterTest.TestRandom() and Analysis.CharFilters.HTMLStripCharFilterTest.TestRandomHugeStrings() tests to fail. Project: http://git-wip-us.apache.org/repos/asf/lucenenet/repo Commit: http://git-wip-us.apache.org/repos/asf/lucenenet/commit/91f06088 Tree: http://git-wip-us.apache.org/repos/asf/lucenenet/tree/91f06088 Diff: http://git-wip-us.apache.org/repos/asf/lucenenet/diff/91f06088 Branch: refs/heads/analysis-work Commit: 91f0608859f1f92c41aeeef29c7a1e8a98ea051b Parents: 196ce64 Author: Shad Storhaug Authored: Fri Aug 26 11:26:42 2016 +0700 Committer: Shad Storhaug Committed: Sat Aug 27 02:17:59 2016 +0700 ---------------------------------------------------------------------- .../Analysis/CharFilter/HTMLStripCharFilter.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/lucenenet/blob/91f06088/src/Lucene.Net.Analysis.Common/Analysis/CharFilter/HTMLStripCharFilter.cs ---------------------------------------------------------------------- diff --git a/src/Lucene.Net.Analysis.Common/Analysis/CharFilter/HTMLStripCharFilter.cs b/src/Lucene.Net.Analysis.Common/Analysis/CharFilter/HTMLStripCharFilter.cs index b0ca65e..cab9206 100644 --- a/src/Lucene.Net.Analysis.Common/Analysis/CharFilter/HTMLStripCharFilter.cs +++ b/src/Lucene.Net.Analysis.Common/Analysis/CharFilter/HTMLStripCharFilter.cs @@ -30879,7 +30879,7 @@ namespace Lucene.Net.Analysis.CharFilters for (; i < len; ++i) { int ch = Read(); - if (ch <= 0) break; + if (ch == -1) break; cbuf[off++] = (char)ch; } return i > 0 ? i : (len == 0 ? 0 : -1); @@ -31006,7 +31006,7 @@ namespace Lucene.Net.Analysis.CharFilters if (numRead == 0) { int c = zzReader.Read(); - if (c <= 0) + if (c == -1) { return true; }