Return-Path: 
 <commits-return-3121-apmail-lucenenet-commits-archive=lucenenet.apache.org@lucenenet.apache.org>
X-Original-To: apmail-lucenenet-commits-archive@www.apache.org
Delivered-To: apmail-lucenenet-commits-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 53E5917F80
	for <apmail-lucenenet-commits-archive@www.apache.org>;
 Tue,  6 Jan 2015 03:46:18 +0000 (UTC)
Received: (qmail 5559 invoked by uid 500); 6 Jan 2015 03:46:19 -0000
Delivered-To: apmail-lucenenet-commits-archive@lucenenet.apache.org
Received: (qmail 5464 invoked by uid 500); 6 Jan 2015 03:46:19 -0000
Mailing-List: contact commits-help@lucenenet.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@lucenenet.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@lucenenet.apache.org>
List-Post: <mailto:commits@lucenenet.apache.org>
List-Id: <commits.lucenenet.apache.org>
Reply-To: lucene-net-dev@lucenenet.apache.org
Delivered-To: mailing list commits@lucenenet.apache.org
Received: (qmail 5294 invoked by uid 99); 6 Jan 2015 03:46:19 -0000
Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org)
 (140.211.11.114)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Jan 2015 03:46:19 +0000
Received: by tyr.zones.apache.org (Postfix, from userid 65534)
	id 043248C641E; Tue,  6 Jan 2015 03:46:18 +0000 (UTC)
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: synhershko@apache.org
To: commits@lucenenet.apache.org
Date: Tue, 06 Jan 2015 03:46:34 -0000
Message-Id: <78f954f263d448ef81d26b85d1d714a7@git.apache.org>
In-Reply-To: <182cdbb11c7749c6bea4975c0322f92a@git.apache.org>
References: <182cdbb11c7749c6bea4975c0322f92a@git.apache.org>
X-Mailer: ASF-Git Admin Mailer
Subject: [18/18] lucenenet git commit: TODOs

TODOs


Project: http://git-wip-us.apache.org/repos/asf/lucenenet/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucenenet/commit/f09cd685
Tree: http://git-wip-us.apache.org/repos/asf/lucenenet/tree/f09cd685
Diff: http://git-wip-us.apache.org/repos/asf/lucenenet/diff/f09cd685

Branch: refs/heads/master
Commit: f09cd685e2a7caed4c2350408ea43ffd8665076f
Parents: a098c0b
Author: Itamar Syn-Hershko <itamar@code972.com>
Authored: Tue Jan 6 02:59:26 2015 +0200
Committer: Itamar Syn-Hershko <itamar@code972.com>
Committed: Tue Jan 6 02:59:26 2015 +0200

----------------------------------------------------------------------
 src/Lucene.Net.Core/Index/IndexReader.cs                | 9 +++++----
 src/Lucene.Net.Tests/core/Index/TestIndexReaderClose.cs | 2 +-
 2 files changed, 6 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucenenet/blob/f09cd685/src/Lucene.Net.Core/Index/IndexReader.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Core/Index/IndexReader.cs b/src/Lucene.Net.Core/Index/IndexReader.cs
index f0fd9fa..9679453 100644
--- a/src/Lucene.Net.Core/Index/IndexReader.cs
+++ b/src/Lucene.Net.Core/Index/IndexReader.cs
@@ -78,7 +78,7 @@ namespace Lucene.Net.Index
         private bool ClosedByChild = false;
         private readonly AtomicInteger refCount = new AtomicInteger(1);
 
-        internal IndexReader()
+        protected IndexReader()
         {
             if (!(this is CompositeReader || this is AtomicReader))
             {
@@ -148,6 +148,7 @@ namespace Lucene.Net.Index
             {
                 foreach (ReaderClosedListener listener in ReaderClosedListeners)
                 {
+                    // LUCENENET TODO
                     /*try
                     {*/
                     listener.OnClose(this);
@@ -328,7 +329,7 @@ namespace Lucene.Net.Index
         /// <summary>
         /// {@inheritDoc}
         /// <p>For caching purposes, {@code IndexReader} subclasses are not allowed
-        /// to implement equals/hashCode, so methods are declared final.
+        /// to implement equals/hashCode, so methods are declared sealed.
         /// To lookup instances from caches use <seealso cref="#getCoreCacheKey"/> and
         /// <seealso cref="#getCombinedCoreAndDeletesKey"/>.
         /// </summary>
@@ -514,7 +515,7 @@ namespace Lucene.Net.Index
         // IndexableField
         public Document Document(int docID)
         {
-            DocumentStoredFieldVisitor visitor = new DocumentStoredFieldVisitor();
+            var visitor = new DocumentStoredFieldVisitor();
             Document(docID, visitor);
             return visitor.Document;
         }
@@ -526,7 +527,7 @@ namespace Lucene.Net.Index
         /// </summary>
         public Document Document(int docID, ISet<string> fieldsToLoad)
         {
-            DocumentStoredFieldVisitor visitor = new DocumentStoredFieldVisitor(fieldsToLoad);
+            var visitor = new DocumentStoredFieldVisitor(fieldsToLoad);
             Document(docID, visitor);
             return visitor.Document;
         }

http://git-wip-us.apache.org/repos/asf/lucenenet/blob/f09cd685/src/Lucene.Net.Tests/core/Index/TestIndexReaderClose.cs
----------------------------------------------------------------------
diff --git a/src/Lucene.Net.Tests/core/Index/TestIndexReaderClose.cs b/src/Lucene.Net.Tests/core/Index/TestIndexReaderClose.cs
index 8c785bd..e1d0bef 100644
--- a/src/Lucene.Net.Tests/core/Index/TestIndexReaderClose.cs
+++ b/src/Lucene.Net.Tests/core/Index/TestIndexReaderClose.cs
@@ -35,7 +35,7 @@ namespace Lucene.Net.Index
         [Test]
         public virtual void TestCloseUnderException()
         {
-            int iters = 1000 + 1 + Random().Next(20);
+            int iters = 1000 + 1 + Random().Next(20); // LUCENENET TODO why so many times? maybe switch to nightly?
             for (int j = 0; j < iters; j++)
             {
                 Directory dir = NewDirectory();