Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: solr-dev@lucene.apache.org
Message-ID: <803756926.536491269799707242.JavaMail.jira@brutus.apache.org>
Date: Sun, 28 Mar 2010 18:08:27 +0000 (UTC)
From: "Shawn Smith (JIRA)" <jira@apache.org>
To: solr-dev@lucene.apache.org
Subject: [jira] Commented: (SOLR-1853) ReplicationHandler reports incorrect
 replication failures
In-Reply-To: <2143516881.536481269799707236.JavaMail.jira@brutus.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SOLR-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850707#action_12850707 ] 

Shawn Smith commented on SOLR-1853:
-----------------------------------

At first glance, it looks like the fix might be as simple as initializing SnapPuller.successfulInstall to true.

> ReplicationHandler reports incorrect replication failures
> ---------------------------------------------------------
>
>                 Key: SOLR-1853
>                 URL: https://issues.apache.org/jira/browse/SOLR-1853
>             Project: Solr
>          Issue Type: Bug
>          Components: replication (java)
>    Affects Versions: 1.4
>         Environment: Linux
>            Reporter: Shawn Smith
>
> The ReplicationHandler "details" command reports that replication failed when it didn't.  This occurs after a slave is restarted when it is already in sync with the master.  This makes it difficult to write production monitors that check the health of master-slave replication (no network issues, unexpected slowdowns, etc).
> From the code, it looks like "SnapPuller.successfulInstall" starts out false on restart.  If the slave starts out in sync with the master, then each no-op replication poll leaves "successfulInstall" set to false which makes SnapPuller.logReplicationTimeAndConfFiles log the poll as a failure.  SnapPuller.successfulInstall stays false until the first time replication actually has to do something, at which point it gets set to true, and then everything is OK.
> h4. Steps to reproduce
> # Setup Solr master and slave servers using Solr 1.4 Java replication.
> # Index some content on the master.  Wait for it to replicate through to the slave so the master and slave are in sync.
> # Stop the slave server.
> # Restart the slave server.
> # Wait for the first slave replication poll.
> # Query the replication status using "http://localhost:8983/solr/replication?command=details"
> # Until the master index changes and there's something to replicate, all slave replication polls after the restart will be shown as failed in the XML response.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.