lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1817) Fix Solr error reporting to work correctly with multicore
Date Wed, 17 Mar 2010 00:39:27 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846242#action_12846242
] 

Mark Miller commented on SOLR-1817:
-----------------------------------

bq. That is the issue where that possible NPE is - getting access to the core name.

  bq.Just ot be clear: it's not just the core name - you've got code that assumes a SolrCore.getCoreDescriptor()
will allways be non null, but that's not allways going to be true.

Right - I'm just saying that I'm doing that to get the corename - I realize the issue with
it, but I need the corename. So when we solve how we are going to handle needing the core
name where we don't have it and need to register an error, hopefully that will apply here
too and we won't need the core descriptor.

Thats what I was thinking at least - now I realize that's dumb - I can just do solrcore.getName()
- wasn't thinking clearly when I put that in I guess. My bad.

> Fix Solr error reporting to work correctly with multicore
> ---------------------------------------------------------
>
>                 Key: SOLR-1817
>                 URL: https://issues.apache.org/jira/browse/SOLR-1817
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Mark Miller
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: SOLR-1817.patch, SOLR-1817.patch, SOLR-1817.patch
>
>
> Here is a rough patch that attempts to fix how error reporting works with multi-core
(not in terms of logs, but what you see on an http request).
> The patch is not done - more to consider and havn't worked with how this changes solrconfigs
abortOnConfigurationError, but the basics are here.
> If you attempt to access the path of a core that could not load, you are shown the errors
that kept the core from properly loading.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message