lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1817) Fix Solr error reporting to work correctly with multicore
Date Wed, 17 Mar 2010 00:23:27 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846230#action_12846230
] 

Hoss Man commented on SOLR-1817:
--------------------------------

Ugh... lots of "cross talk", sorry still procesisng some of your earlier comments...

{quote}
That check is actually just there so that if you ask for solr/admin, you will end up getting
the "" core - so it makes sense to only allow it in if the corename is admin anyway.

Though I have never really liked that logic where it looks for the admin core and when it
can't find it it drops to the "" core.
{quote}

Hmmm... so then this is special behavior needed to make the "admin/*.jsp" type URLs work with
the default core?

then why was this check only added as part of your patch for this issue?  how do the admin
JSPs work on the current trunk?

In either case: why do we need to specificly test for "admin" shouldn't that code path just
fall through regardless of the patch? ie: 
{code}
if (core == null && errors == null) { 
  corename=""; 
  core=cores.getCore(corename); 
}
{code}

? 


> Fix Solr error reporting to work correctly with multicore
> ---------------------------------------------------------
>
>                 Key: SOLR-1817
>                 URL: https://issues.apache.org/jira/browse/SOLR-1817
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Mark Miller
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: SOLR-1817.patch, SOLR-1817.patch, SOLR-1817.patch
>
>
> Here is a rough patch that attempts to fix how error reporting works with multi-core
(not in terms of logs, but what you see on an http request).
> The patch is not done - more to consider and havn't worked with how this changes solrconfigs
abortOnConfigurationError, but the basics are here.
> If you attempt to access the path of a core that could not load, you are shown the errors
that kept the core from properly loading.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message