lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1857) cleanup and sync analysis with lucene trunk
Date Wed, 31 Mar 2010 20:53:27 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852094#action_12852094
] 

Yonik Seeley commented on SOLR-1857:
------------------------------------

I just did a 5 min review, not line-by-line, but seems fine in general.

> cleanup and sync analysis with lucene trunk
> -------------------------------------------
>
>                 Key: SOLR-1857
>                 URL: https://issues.apache.org/jira/browse/SOLR-1857
>             Project: Solr
>          Issue Type: Task
>          Components: Schema and Analysis
>    Affects Versions: 3.1
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: 3.1
>
>         Attachments: SOLR-1857.patch
>
>
> Solr works on the lucene trunk, but uses a lot of deprecated APIs.
> Additionally two factories are missing, the Keyword and StemmerOverride filters.
> The code can be improved with 3.x's generics support, removing casts, etc.
> Finally there is some code duplication with lucene, and some cleanup (such as deprecating
factories for stuff thats deprecated in trunk).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message