lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1817) Fix Solr error reporting to work correctly with multicore
Date Fri, 19 Mar 2010 00:44:27 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847174#action_12847174
] 

Hoss Man commented on SOLR-1817:
--------------------------------

I started looking a little more closely at the singleton SolrCOnfig.severErrors, since eliminating
usage of it is really the key to being able to support abortOnConfigurationError=true/false
for multiple cores independently.  The more I looked at it, the more this whole thing seems
futile.

For starters:  I discovered SOLR-1832 ... in a nutshell a failure to init most types of plugins
in 1.4 causes SolrCore to fail to init, regardless of whether abortOnConfigurationError=false.
 The only types of plugins where initialization failures are logged but the remaining instances
are loaded anyway is RequestHandlers and schema related classes (ie: FieldType and Token*Factories)
... but as noted in SOLR-1824 it's actually a really, really, REALLY bad thing for IndexSchema
to "ignore" when a FieldType or analysis factory can't be initialized, because it could result
in incorrect values getting indexed.

So we could:
* fix SOLR-1824 so that any init error in IndexSchema caused a hard fail.
* fix SOLR-1832 so that SolrCore.initPlugins "skipped" any instances that failed to init and
recorded the exceptions directly with the SolrCore.
* officially deprecated the *PluginLoader classes, and remove the spots where it adds to SolrCOnfig.severErrors

...so then we wouldn't have anyone writting to SolrCOnfig.severErrors anymore.

But should we even bother?

I'm starting to think the whole idea of abortOnConfigurationError is a bad idea ... especially
if no one noticed SOLR-1832 before now.  Maybe we should just kill the whole concept, and
have SolrCore initialization fail fast and propogate any type of Exception up to CoreContainer?



> Fix Solr error reporting to work correctly with multicore
> ---------------------------------------------------------
>
>                 Key: SOLR-1817
>                 URL: https://issues.apache.org/jira/browse/SOLR-1817
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Mark Miller
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: SOLR-1817.patch, SOLR-1817.patch, SOLR-1817.patch
>
>
> Here is a rough patch that attempts to fix how error reporting works with multi-core
(not in terms of logs, but what you see on an http request).
> The patch is not done - more to consider and havn't worked with how this changes solrconfigs
abortOnConfigurationError, but the basics are here.
> If you attempt to access the path of a core that could not load, you are shown the errors
that kept the core from properly loading.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message