lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <>
Subject [jira] Resolved: (SOLR-1792) Document peculiar behavior of TestHarness.LocalRequestFactory
Date Wed, 24 Feb 2010 02:11:29 GMT


Hoss Man resolved SOLR-1792.

    Resolution: Fixed

Committed revision 915637.

> Document peculiar behavior of TestHarness.LocalRequestFactory
> -------------------------------------------------------------
>                 Key: SOLR-1792
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.1.0, 1.2, 1.3, 1.4
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>             Fix For: 1.5
>         Attachments: SOLR-1792.patch
> While working on a test case, i realized that due to method evolution, TestHarness.LocalRequestFactory.makeRequest
has some really odd behavior that results in the "defaults" the factory was configured with
being ignored when the method is called with multiple varargs.
> I spent some time attempting to "fix" this by adding the defaults to the end of the params,
but then discovered that this breaks existing tests because the LRF defaults take precedence
over defaults that may be hardcoded into the solrconfig.xml.  The internal test might be changed
to work arround this, but i didn't want to risk breaking tests for users who might be using
TestHarness directly.
> So this bug is just to track improving the documentation of what exactly LRF.makeRequest
does with it's input

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message