Return-Path: Delivered-To: apmail-lucene-solr-dev-archive@minotaur.apache.org Received: (qmail 39094 invoked from network); 5 Jan 2010 05:27:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 5 Jan 2010 05:27:23 -0000 Received: (qmail 72017 invoked by uid 500); 5 Jan 2010 05:27:22 -0000 Delivered-To: apmail-lucene-solr-dev-archive@lucene.apache.org Received: (qmail 71922 invoked by uid 500); 5 Jan 2010 05:27:22 -0000 Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: solr-dev@lucene.apache.org Delivered-To: mailing list solr-dev@lucene.apache.org Received: (qmail 71912 invoked by uid 99); 5 Jan 2010 05:27:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2010 05:27:22 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2010 05:27:20 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 63853234C48C for ; Mon, 4 Jan 2010 21:26:59 -0800 (PST) Message-ID: <675247385.36201262669219406.JavaMail.jira@brutus.apache.org> Date: Tue, 5 Jan 2010 05:26:59 +0000 (UTC) From: "Noble Paul (JIRA)" To: solr-dev@lucene.apache.org Subject: [jira] Commented: (SOLR-1682) Implement CollapseComponent In-Reply-To: <1947458636.1261428318168.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SOLR-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796529#action_12796529 ] Noble Paul commented on SOLR-1682: ---------------------------------- bq. But now also a search is done twice. Shouldn't it be better to have two complete distinct collectors that don't depend on one another? Both the collectors are designed to complement each other so that one can piggyback on other and minimize the code/work bq. The field group.numFound is then added as well. Why did you gave it a different name? The names are up for debate . Let us reach a consensus on that . When collapse.threshhold=1 collapse.cout/collapse.groupSize can be avoided > Implement CollapseComponent > --------------------------- > > Key: SOLR-1682 > URL: https://issues.apache.org/jira/browse/SOLR-1682 > Project: Solr > Issue Type: Sub-task > Components: search > Reporter: Martijn van Groningen > Assignee: Shalin Shekhar Mangar > Fix For: 1.5 > > Attachments: field-collapsing.patch, SOLR-1682.patch, SOLR-236.patch > > > Child issue of SOLR-236. This issue is dedicated to field collapsing in general and all its code (CollapseComponent, DocumentCollapsers and CollapseCollectors). The main goal is the finalize the request parameters and response format. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.