lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yonik Seeley <yo...@lucidimagination.com>
Subject Re: svn commit: r895056 - in /lucene/solr/branches/cloud/src: java/org/apache/solr/cloud/ webapp/web/admin/
Date Fri, 01 Jan 2010 19:42:00 GMT
On Fri, Jan 1, 2010 at 2:20 PM,  <markrmiller@apache.org> wrote:
> ==============================================================================
> --- lucene/solr/branches/cloud/src/webapp/web/admin/zookeeper.jsp (original)
> +++ lucene/solr/branches/cloud/src/webapp/web/admin/zookeeper.jsp Fri Jan  1 19:20:26
2010
> @@ -391,6 +391,11 @@
>           try {
>             str = new String(data, "UTF-8");
>           } catch (UnsupportedEncodingException e) {
> +            // nocommit : does this make sense? isn't UTF-8
> +            // gauranteed to be supported? I don't think this is thrown
> +            // because its not UTF-8 is it? The results are unspecified
> +            // when the bytes are not properly encoded.

Hmmm, yeah, we need a better way to detect malformed UTF-8 to fall
back to binary....
if (str.indexOf(utf_replacement_string) >= 0) ?

-Yonik
http://www.lucidimagination.com

Mime
View raw message