lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <>
Subject [jira] Commented: (SOLR-1603) Perl Response Writer
Date Thu, 28 Jan 2010 20:49:34 GMT


Yonik Seeley commented on SOLR-1603:

First, some history and motivation from my POV:
The original goal was JSON... but it was just so close to some other interpreted languages
like Python, that I implemented that too since it was almost free.  That, and I've been a
long-time python user, but at the time I don't think any JSON libs were bundled, and if any
XML libs were bundled, I had never used them.  I did know how to "eval()" though - nice and
simple.  And then Ruby was a hot language, so I did that too because I thought some of those
guys might appreciate it.

Security: when talking to Solr, the client is in control of what format is returned - if you
are talking to trusted servers, use whatever format you want.  If you're hitting some remote
server on the internet somewhere that you don't have control over, don't trust it period.
 Don't even trust the data from it.  If people are feeding you malicious data, it's not like
switching to JSON or XML will magically fix the security issues anyway.  The vast majority
of Solr clients talk directly to trusted solr servers... this isn't an issue for most people.

Tests: yes, I got lazy.  It's actually very hard to do a good test for this stuff w/o making
the tests too fragile.  I tested by hand via cut-n-paste and eval() in a real target interpreter.

Usefulness: I still use the python format all the time, for the simple reason that since that
character set of a python script wasn't well defined at the time, I stuck to ASCII and used
unicode escape sequences for everything else.  When I suspect charset issues now, I automatically
go to the python response format to see what the actual numeric values are of anything outside

Bottom line: will perl people like this or not?  If so, put it in, it's small!

> Perl Response Writer
> --------------------
>                 Key: SOLR-1603
>                 URL:
>             Project: Solr
>          Issue Type: New Feature
>          Components: Response Writers
>            Reporter: Claudio Valente
>            Priority: Minor
>         Attachments: SOLR-1603.patch
> I've made a patch that implements a Perl response writer for Solr.
> It's nan/inf and unicode aware.
> I don't know whether some fields can be binary but if so I can probably extend it to
support that.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message