lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris A. Mattmann (JIRA)" <>
Subject [jira] Commented: (SOLR-1688) Inner class FieldCacheSources should be refactored into their own classes
Date Wed, 13 Jan 2010 06:45:54 GMT


Chris A. Mattmann commented on SOLR-1688:

Hi All,

Yonik, what do you think on this one? The patch I put up at least follows a single policy
and has rationale rather than the existing code which does not (see comments above). What's
the compromise here? Let's get this cleaned up! :)


> Inner class FieldCacheSources should be refactored into their own classes
> -------------------------------------------------------------------------
>                 Key: SOLR-1688
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.4
>         Environment: indep. of env.
>            Reporter: Chris A. Mattmann
>             Fix For: 1.5
>         Attachments: SOLR-1688.Mattmann.122609.patch.txt
> While working on SOLR-1586 I noticed that outside of class level access (or package level),
you can't really reference FieldCacheSources that are defined inside of their FieldType constituents
(e.g., in the case of StrFieldSource as defined in StrField). What's more troubling is that
the FieldType/FieldCacheSources are defined in an inconsistent fashion: some are done as inner
classes, e.g., StrFieldSource and SortableFloatFieldSource, while others are defined as individual
classes (e.g., FloatFIeldSource). This patch will make them all consistent and define each
FieldCacheSource as an outside class, present in

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message