lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "patrick o'leary (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1602) Refactor SOLR package structure to include o.a.solr.response and move QueryResponseWriters in there
Date Sat, 02 Jan 2010 20:01:54 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795907#action_12795907
] 

patrick o'leary commented on SOLR-1602:
---------------------------------------

I've been writing plugin's for solr for a couple of years, and I have seen several situations
when we broke backwards compatibility, and configuration for absolutely no reasonable reason
except for refactoring for the sake of refactoring.

One that springs to mind is updateRequestProcessor going to updateRequestProcessorChain.
Along with many more that over the years have caused me and anyone else who consumes solr
to realize that upgrades
cost time and money.

Why should this be different? 
This at least, cleans things up, the deprecations strategy used in the past have caused more
headache than anything,
we deprecate, leave a class in place, sometimes even empty out the class so does nothing....

and force folks to use 'find' and 'grep' as a way to get solr working. 
Look at SOLR-489, as a prime example, that it's just not been a good practice in the past.

To me that's not a helpful way to refactor. 


> Refactor SOLR package structure to include o.a.solr.response and move QueryResponseWriters
in there
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-1602
>                 URL: https://issues.apache.org/jira/browse/SOLR-1602
>             Project: Solr
>          Issue Type: Improvement
>          Components: Response Writers
>    Affects Versions: 1.2, 1.3, 1.4
>         Environment: independent of environment (code structure)
>            Reporter: Chris A. Mattmann
>            Assignee: Noble Paul
>             Fix For: 1.5
>
>         Attachments: SOLR-1602.Mattmann.112509.patch.txt, SOLR-1602.Mattmann.112509_02.patch.txt,
upgrade_solr_config
>
>
> Currently all o.a.solr.request.QueryResponseWriter implementations are curiously located
in the o.a.solr.request package. Not only is this package getting big (30+ classes), a lot
of them are misplaced. There should be a first-class o.a.solr.response package, and the response
related classes should be given a home there. Patch forthcoming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message