lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Hatcher (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-1602) Refactor SOLR package structure to include o.a.solr.response and move QueryResponseWriters in there
Date Sat, 02 Jan 2010 11:13:54 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795854#action_12795854
] 

Erik Hatcher commented on SOLR-1602:
------------------------------------

Chris - you sure do go to an extreme of lots of typing to try to make your case when you've
got two committers (and likely a user community consensus) saying deprecation is required.
  It's easy enough, and really makes a big difference to the _sysadmin_ that'll be the one
to deploy a new version of Solr. 

Consider the *dramatic* changes that go on with the Lucene index format itself, and it remains
backwards compatible for a version or more.  What if we told users they had to reindex everything?
 And you're proposing we make life more difficult for end users for an internal package move?!
   You're not killing two birds with one stone, you're killing user A's valuable time.

I'll even add that for this to be commit-ready that a log message should be made in the deprecated
classes to alert the user of the move. 


> Refactor SOLR package structure to include o.a.solr.response and move QueryResponseWriters
in there
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-1602
>                 URL: https://issues.apache.org/jira/browse/SOLR-1602
>             Project: Solr
>          Issue Type: Improvement
>          Components: Response Writers
>    Affects Versions: 1.2, 1.3, 1.4
>         Environment: independent of environment (code structure)
>            Reporter: Chris A. Mattmann
>            Assignee: Noble Paul
>             Fix For: 1.5
>
>         Attachments: SOLR-1602.Mattmann.112509.patch.txt, SOLR-1602.Mattmann.112509_02.patch.txt
>
>
> Currently all o.a.solr.request.QueryResponseWriter implementations are curiously located
in the o.a.solr.request package. Not only is this package getting big (30+ classes), a lot
of them are misplaced. There should be a first-class o.a.solr.response package, and the response
related classes should be given a home there. Patch forthcoming.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message